Skip to content

Conversation

@ljain112
Copy link
Collaborator

@ljain112 ljain112 commented Nov 28, 2025

Before:
image

After:
image

closes: #50324 (Alternative solution)
closes: #48854

@ljain112 ljain112 requested a review from khushi8112 as a code owner November 28, 2025 07:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

📝 Walkthrough

Walkthrough

This change modifies the Asset Repair doctype configuration file to add a new link to Stock Entry documents. The modification updates the links section of the Asset Repair JSON schema, establishing a relationship with Stock Entry records via the "asset_repair" fieldname. The doctype's modification timestamp was updated accordingly.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single configuration file change with minimal scope
  • Addition of a straightforward link entry to doctype metadata
  • No logic changes or cross-file dependencies

Suggested Labels

needs-tests

Suggested Reviewers

  • khushi8112

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR partially addresses issue #50324 by adding a Stock Entry link, but the issue requests a 'Stock Ledger' button with specific functionality to display stock ledger entries for consumed items, which appears to be a different implementation approach. Verify that the Stock Entry link functionality meets the original requirement to display stock ledger entries for consumed items, or clarify if this is an alternative solution to the requested Stock Ledger button.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a Stock Entry link to the Asset Repair doctype, which directly matches the code modification in the changeset.
Out of Scope Changes check ✅ Passed The changes are limited to adding a Stock Entry link to the Asset Repair doctype configuration file, which is directly aligned with the PR objectives and linked issue requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The description includes before/after screenshots and references specific issues being closed, directly relating to the changeset of adding a Stock Entry link to the Asset Repair doctype.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ljain112 ljain112 added the backport version-16-beta Backport to the Version 16 Beta branch label Nov 28, 2025
@khushi8112 khushi8112 merged commit 82b6326 into frappe:develop Nov 28, 2025
16 checks passed
khushi8112 added a commit that referenced this pull request Nov 28, 2025
…0792

fix: add Stock Entry link to Asset Repair doctype. (backport #50792)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport version-16-beta Backport to the Version 16 Beta branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Stock Ledger Button in Asset Repair Doctype feat: Stock Entry link with Asset Repair

2 participants