Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

Commit 3e21ed9

Browse files
committed
cope with pandas not using semantic versioning: add upper version constraint due to renaming of get_filepath_or_buffer
pandas-dev/pandas#37639 pandas-dev/pandas@6d1541e#diff-934d8564d648e7521db673c6399dcac98e45adfd5230ba47d3aabfcc21979febL247 PEtab-dev/PEtab#493
1 parent 097062f commit 3e21ed9

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

setup.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,12 @@
6868
packages=setuptools.find_packages(),
6969
install_requires=[
7070
"numpy<2",
71-
# hoping pandas maintainers use semantic versioning
71+
# pandas v1.2.0 made `get_filepath_or_buffer` private without releasing major version.
72+
# semver?!? not even mentioned in changelog
73+
# https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.2.0.html
74+
# https://github.com/pandas-dev/pandas/commit/6d1541e1782a7b94797d5432922e64a97934cfa4#diff-934d8564d648e7521db673c6399dcac98e45adfd5230ba47d3aabfcc21979febL247
7275
# TODO verify lower version constraint
73-
"pandas>=0.21,<2",
76+
"pandas>=0.21,<1.2",
7477
],
7578
setup_requires=["setuptools_scm"],
7679
tests_require=["pytest<5"],

0 commit comments

Comments
 (0)