Skip to content

chore: remove wasm cfgs#61

Merged
DaniPopes merged 1 commit intomainfrom
dani/rm-wasm
Jan 30, 2024
Merged

chore: remove wasm cfgs#61
DaniPopes merged 1 commit intomainfrom
dani/rm-wasm

Conversation

@DaniPopes
Copy link
Member

No description provided.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

the failing windows install test could be because older windows releases are weird, IIRC they are zip files with some dll or smth, we could just skip them

Comment on lines +2 to +10
// #![warn(
// missing_copy_implementations,
// missing_debug_implementations,
// missing_docs,
// unreachable_pub,
// clippy::missing_const_for_fn,
// rustdoc::all
// )]
// #![cfg_attr(not(test), warn(unused_crate_dependencies))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we enable these, or remove?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next PR in line

@DaniPopes DaniPopes merged commit dbb5df0 into main Jan 30, 2024
@DaniPopes DaniPopes deleted the dani/rm-wasm branch January 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants