fix: add snake_case aliases for ModelCheckerSettings fields#348
Merged
grandizzy merged 1 commit intofoundry-rs:mainfrom Jan 20, 2026
Merged
Conversation
Fixes foundry-rs/foundry#12801 The ModelCheckerSettings struct uses camelCase for solc JSON compatibility, but Foundry's foundry.toml uses snake_case. This adds serde aliases so both formats work for deserialization while maintaining camelCase serialization.
grandizzy
requested review from
0xrusowsky,
DaniPopes,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
zerosnacks
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ref foundry-rs/foundry#12801 (should bump before closing issue)
The
ModelCheckerSettingsstruct uses#[serde(rename_all = "camelCase")]for compatibility with solc's JSON input format. However, Foundry'sfoundry.tomlconfig uses snake_case for field names (e.g.,show_unproved = true).This mismatch causes the following model_checker config fields to be silently ignored when parsing
foundry.toml:show_unprovedshow_unsupportedshow_proved_safediv_mod_with_slacksSolution
Add
#[serde(alias = "snake_case_name")]to the affected fields. This allows deserialization from both:showUnproved) - for solc JSON input compatibilityshow_unproved) - for foundry.toml config compatibilitySerialization continues to produce camelCase output, maintaining solc compatibility.
Test Plan
Added
model_checker_settings_snake_case_aliasestest that verifies: