fix: sort remapping candidates to avoid non deterministic output#343
Merged
DaniPopes merged 2 commits intofoundry-rs:mainfrom Jan 19, 2026
Merged
fix: sort remapping candidates to avoid non deterministic output#343DaniPopes merged 2 commits intofoundry-rs:mainfrom
DaniPopes merged 2 commits intofoundry-rs:mainfrom
Conversation
Jrigada
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
DaniPopes
approved these changes
Jan 19, 2026
Jrigada
added a commit
to matter-labs/foundry-zksync
that referenced
this pull request
Jan 19, 2026
The remapping sorting fix (foundry-rs/compilers#343) has been merged and released in foundry-compilers 0.19.12. This removes the temporary fork patch (nbaztec/compilers) that was used as a workaround.
Merged
2 tasks
nbaztec
pushed a commit
to matter-labs/foundry-zksync
that referenced
this pull request
Jan 19, 2026
The remapping sorting fix (foundry-rs/compilers#343) has been merged and released in foundry-compilers 0.19.12. This removes the temporary fork patch (nbaztec/compilers) that was used as a workaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a non-determinism issue in remapping generation that was causing contracts to produce different compilation hashes across operating systems (see matter-labs/foundry-zksync#1188).
Problem
fs::read_dirreturns directory entries in an arbitrary order that varies between platforms (e.g., macOS vs Ubuntu). When multiple remapping candidates exist, they get processed and output in different orders depending on the system, leading to inconsistent compilation hashes for the same contracts.Fix
Sort remapping candidates before processing to ensure consistent and reproducible output regardless of the underlying filesystem behavior.