Merged
Conversation
TilakMaddy
requested review from
DaniPopes,
klkvr and
mattsse
as code owners
klkvr
pushed a commit
that referenced
this pull request
Sep 16, 2024
Fix for 2 ast node bindings * BinaryOperation can qualify as an `expr_node!` * Return AST Node's `function_return_parameters` should be made optional because when return is used inside modifiers, the AST generated by solc doesn't include the `function_return_parameters` field More context: I tried using these changes on [Aderyn](https://github.com/Cyfrin/aderyn/blob/5c483fdbf1f454ca42c1fd9b85353b0b9241c43a/aderyn_core/src/ast/ast_nodes.rs#L639C1-L645C3) for a while and haven't come across an unrecognized node since :) So I thought I'll share it with ya!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for 2 ast node bindings
expr_node!function_return_parametersshould be made optional because when return is used inside modifiers, the AST generated by solc doesn't include thefunction_return_parametersfieldMore context:
I tried using these changes on Aderyn for a while and haven't come across an unrecognized node since :) So I thought I'll share it with ya!