feat: always provide Default for MultiCompiler#188
Merged
Conversation
klkvr
force-pushed
the
klkvr/default-svm-solc
branch
from
adc88db to
32f2248
Compare
DaniPopes
approved these changes
Aug 18, 2024
klkvr
force-pushed
the
klkvr/default-svm-solc
branch
from
32f2248 to
eb9e75e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187
Closes #168
Updates
MultiCompilerand makes solc compiler on it optional. Ifsvm-solcis not activated, it is attempted to initialize solc viaSolc::new("solc"), and if solc binary is not available in command line, it is set to None.We could also add
svm-solcto default features as I think people would often prefer enabling it as it's required to emulate foundry's default behavior.