Conversation
mattsse
approved these changes
Jul 17, 2024
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
makes sense but should we introduce an enum for this, like evmversion?
Member
Author
I believe it is a one-byte number by spec: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-3540.md#header |
Member
|
yeah could we make an enum for that? |
Member
Author
|
Added enum in c04da87 |
mattsse
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds key for enabling eof which is supported by https://github.com/ipsilon/solidity/tree/eof-functions-rebased
solc allows unknown keys in settings, so setting this wouldn't break default solc. though I think it might make sense to be under a feature flag. wdyt @mattsse