refactor: extract artifacts to a separate crate#142
Merged
Conversation
klkvr
changed the title
DaniPopes
reviewed
Jun 13, 2024
mattsse
requested changes
Jun 13, 2024
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
splitting into
artifacts
core
compilers
makes sense
I suggest to do a foundry companion first before we merge this so that we can fix things like missing re-exports etc.
crates/project/src/lib.rs
Outdated
Comment on lines
+53
to
+57
| use foundry_compilers_artifacts::{ | ||
| output_selection::OutputSelection, | ||
| sources::{Source, Sources}, | ||
| Contract, Settings, Severity, SourceFile, StandardJsonCompilerInput, | ||
| }; |
Member
There was a problem hiding this comment.
we likely want to re-export
foundry_compilers_artifacts as artifacts
so that you don't need to depend on all crates if you're already pulling in compilers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129
Divides
foundry-compilersinto 3 crates:foundry-compilers-artifacts- JSON artifacts for Solc and Vyper compilersfoundry-compilers-project- Project related logic, including compiler abstraction and compilation pipelinefoundry-compilers-core- error types and utilties shared by both crates