Merged
Conversation
mattsse
approved these changes
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Vyper path resolution does not correctly handle relative paths (
from . import X,from .. import X).This PR fixes this and changes parser to parse into
VyperImportwhich tracksfinal_part(X atfrom ... import Xexpression).Currently vyper allows doing imports like
from Contract import Contractwhich is equivalent toimport Contract as Contractand only requiresContract.vyto be present. However, such format is only supported when invokingvyperfrom command like, and for standard JSON input it does not work, which is why we can't compile snekmate right away without small import fixes.I believe in the future Vyper versions that will be fixed and thus
VyperImporttracksfinal_partadditionaly.Also added more tests for path resolution