Skip to content

fix: insert link in description field #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2020
Merged

fix: insert link in description field #5023

merged 2 commits into from
Sep 10, 2020

Conversation

@maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Sep 9, 2020 •
edited
Loading

Fixes #5017

Screenshot from 2020-09-09 13-01-38
Screenshot from 2020-09-09 13-00-44
Screenshot from 2020-09-09 13-00-27

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 9, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ranooj2ex
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-1.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020 •
edited
Loading

Codecov Report

Merging #5023 into development will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5023      +/-   ##
===============================================
+ Coverage        22.67%   22.69%   +0.01%     
===============================================
  Files              485      485              
  Lines             5151     5165      +14     
  Branches            21       21              
===============================================
+ Hits              1168     1172       +4     
- Misses            3979     3989      +10     
  Partials             4        4
Impacted Files Coverage Δ
app/mixins/event-wizard.js 1.07% <0.00%> (-0.07%) ⬇️
app/models/event.js 53.84% <0.00%> (ø)
app/components/widgets/time-zone-picker.ts 33.33% <0.00%> (ø)
app/components/forms/wizard/basic-details-step.js 21.51% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b50dd4...ca18cd2. Read the comment docs.

snitin315
snitin315 reviewed Sep 9, 2020
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfect but there is one issue when we create a new event the createLink popup is active by default and not hidden.

Screenshot at 2020-09-09 17-18-02

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Sep 9, 2020

Works perfect but there is one issue when we create a new event the createLink popup is active by default and not hidden.

Screenshot at 2020-09-09 17-18-02

Any suggestions for this, it is just by default.

snitin315
snitin315 reviewed Sep 9, 2020
View reviewed changes
app/templates/components/widgets/forms/rich-text-editor.hbs Outdated
<div class="ui icon buttons">
<a href="#" class="ui button" data-wysihtml5-command="createLink" data-content="{{t 'Insert Link'}}" ><i class="linkify icon"></i></a>
</div>
<div data-wysihtml5-dialog="createLink" class="mb-8">
Copy link
Member

@snitin315 snitin315 Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if this works?

Suggested change
<div data-wysihtml5-dialog="createLink" class="mb-8">
<div data-wysihtml5-dialog="createLink" class="mb-8" style="display: 'none' ">

Refers https://github.com/Voog/wysihtml/blob/3f7a34a2721813c81c3b2205a9bfff8b8e472eff/examples/advanced_div.html#L262-L268

Copy link
Contributor Author

@maze-runnar maze-runnar Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks man 👍

snitin315
snitin315 approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@iamareebjamal iamareebjamal merged commit a98c6a7 into fossasia:development Sep 10, 2020
@maze-runnar maze-runnar deleted the patch-1 branch December 13, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+1 more reviewer

@snitin315 snitin315 snitin315 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wizard Step 1 / Public Event Page: Description Cannot add Links

3 participants

@maze-runnar @iamareebjamal @snitin315