Skip to content

Conversation

@Santiagomrn
Copy link

@Santiagomrn Santiagomrn commented Apr 24, 2024

#833

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@titanism
Copy link
Collaborator

Closing in favor of #834 - if you had thoughts/argument as to why your approach is better please let us know

@titanism titanism closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants