Skip to content

fix tests on nightly #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2024
Merged

fix tests on nightly #2786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dc9ecb
fix tests on nightly
Pangoraw Jan 21, 2024
c559db9
Update helpers.jl
Pangoraw Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
fail-fast: false
matrix:
# We test quite a lot of versions because we do some OS and version specific things unfortunately
julia-version: ["1.6", "1.8", "1.10"] #, "nightly"] # "~1.11.0-0"]
julia-version: ["1.6", "1.8", "1.10", "nightly"] # "~1.11.0-0"]
os: [ubuntu-latest, macOS-latest, windows-latest]

steps:
Expand Down
11 changes: 8 additions & 3 deletions test/helpers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,14 @@ end

function expecterror(err, cell; strict=true)
cell.errored || return false
io = IOBuffer()
showerror(io, err)
msg = String(take!(io))
msg = sprint(showerror, err)

# UndefVarError(:x, #undef)
if err isa UndefVarError && !isdefined(err, :scope) && VERSION > v"1.10"
strict = false
msg = first(split(msg, '\n'; limit=2))
end

if strict
return cell.output.body[:msg] == msg
else
Expand Down