Conversation
ExecAdapter's deny output did not show the matched rule pattern,
making it hard for LLM agents to understand why a command was rejected
and how to fix it. HookAdapter's permissionDecisionReason only included
the message but omitted the matched rule and fix_suggestion.
ExecAdapter now outputs a structured format:
runok: denied: <matched_rule>
reason: <message>
suggestion: <fix_suggestion>
HookAdapter now builds a combined reason string that includes the
matched rule, message, and fix_suggestion in permissionDecisionReason.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Summary of ChangesHello @fohte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the clarity and detail of deny feedback across different adapters. By structuring the output for Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully improves the feedback provided when a command is denied by including the matched rule, an optional reason, and an optional fix suggestion. These changes are correctly implemented in both ExecAdapter for CLI output and ClaudeCodeHookAdapter for JSON-based hook responses. The implementation is clean, maintains consistency with existing patterns, and includes appropriate test coverage for the new message formats. No significant issues or bugs were identified during the review.
Why
What
ExecAdapterdeny stderr output to show matched rule, reason, and fix suggestion on separate linesClaudeCodeHookAdapter'spermissionDecisionReason