feat(rules): support command extraction from subshells#23
Conversation
extract_commands() did not recurse into subshell nodes like `(cmd1 && cmd2)`, treating the entire parenthesized group as a single opaque command string. This prevented the permission engine from evaluating individual commands within subshells. Add `"subshell"` to the set of compound constructs that collect_commands() recurses into, so `(cmd1 && cmd2) | cmd3` correctly yields three separate commands. Also add test coverage for logical operator chains, subshells, process substitution preservation, heredocs, and whitespace handling.
Summary of ChangesHello @fohte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the command parsing capabilities by enabling the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly extends the command extraction logic to support subshells by recursively traversing subshell nodes in the AST. The implementation is straightforward and effective. The accompanying tests cover several important cases, including logical operators, subshells in pipelines, process substitution, and heredocs. I've suggested a couple of improvements to the new tests to make them more robust and descriptive, covering more complex nesting and whitespace scenarios. Overall, this is a solid contribution that addresses the stated goal.
src/rules/command_parser.rs
Outdated
| let result = extract_commands(" cmd1 && cmd2 ").unwrap(); | ||
| assert_eq!(result, vec!["cmd1", "cmd2"]); |
There was a problem hiding this comment.
The current whitespace test is good, but it could be more comprehensive. It mainly tests the trim() on the overall input string in extract_commands. To also validate the trim() on individual command segments within collect_commands, consider a more complex case involving internal whitespace and subshells.
| let result = extract_commands(" cmd1 && cmd2 ").unwrap(); | |
| assert_eq!(result, vec!["cmd1", "cmd2"]); | |
| let result = extract_commands(" cmd1 && cmd2 | ( cmd3 ) ").unwrap(); | |
| assert_eq!(result, vec!["cmd1", "cmd2", "cmd3"]); |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Reviewer pointed out that `extract_nested_subshell` was misleading (it tested a subshell in a logical chain, not truly nested subshells) and that whitespace tests lacked subshell coverage. Rename to `extract_subshell_in_logical_chain`, add a genuine nested subshell test using `(cmd1 | (cmd2 ; cmd3))`, and add a whitespace test combining operators with subshells.
Individual #[test] functions with identical assert patterns were scattered across multiple sections, making it harder to scan and extend the test suite. Consolidate into parameterized rstest groups: compound commands, subshell, special constructs, whitespace, and error cases.
1 participant
Why
extract_commands()to decompose compound commands inside subshells ((...)) so that each individual command can be evaluatedWhat
(cmd1 && cmd2) | cmd3correctly yields three separate commands