insert else branch to avoid unreachable code warning (#4130)

torsten48 · web-flow · commit bbf8b3bd0178 · 2024-08-28T16:43:12.000-07:00
at least MSC caused warning C4702: unreachable code
diff --git a/include/fmt/compile.h b/include/fmt/compile.h
@@ -143,8 +143,9 @@ template <typename Char, typename T, int N> struct field {
     if constexpr (std::is_convertible<T, basic_string_view<Char>>::value) {
       auto s = basic_string_view<Char>(arg);
       return copy<Char>(s.begin(), s.end(), out);
+    } else {
+      return write<Char>(out, arg);
     }
-    return write<Char>(out, arg);
   }
 };
 

Original file line number	Diff line number	Diff line change
`@@ -143,8 +143,9 @@ template <typename Char, typename T, int N> struct field {`
`143`	`143`	`if constexpr (std::is_convertible<T, basic_string_view<Char>>::value) {`
`144`	`144`	`auto s = basic_string_view<Char>(arg);`
`145`	`145`	`return copy<Char>(s.begin(), s.end(), out);`
	`146`	`+ } else {`
	`147`	`+ return write<Char>(out, arg);`
`146`	`148`	`}`
`147`		`- return write<Char>(out, arg);`
`148`	`149`	`}`
`149`	`150`	`};`
`150`	`151`