From a486bcdfa1294c362f4bbefb78da2774d4ff4a1c Mon Sep 17 00:00:00 2001 From: hangyu Date: Fri, 13 Dec 2024 12:54:57 -0800 Subject: [PATCH 01/12] Create deep-links-flag-change.md --- .../deep-links-flag-change.md | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 src/content/release/breaking-changes/deep-links-flag-change.md diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md new file mode 100644 index 00000000000..1cc13a87bc6 --- /dev/null +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -0,0 +1,61 @@ +--- +title: Deep links flag change +description: >- + +--- + +## Summary + +The default value for Flutter’s deep linking flag has changed from false to true, meaning deep linking is now opt-in by default. + +## Migration guide + + +If you’re using Flutter’s default deep linking setup, there’s no need to manually set the flag to true anymore. + +However, if you’re using third-party plugins for deep links, such as: + +[firebase dynamic links][https://firebase.google.com/docs/dynamic-links] +[uni_link][https://pub.dev/packages/uni_links] +[app_links][https://pub.dev/packages/app_links] +This update will introduce a breaking change. In this case, you’ll need to manually reset the Flutter deep linking flag to false. + +Before: non-op + +After: + +Manually disable the deep linking flag if you're using third-party plugins: + +* Android Manifest file + +```dart + + + + + + +``` + +* iOS info.plist file + +``` + FlutterDeepLinkingEnabled + +``` + +## Timeline + +Landed in version: 3.27.0-0.0.pre
+Stable release: 3.27 + +## References + +Design documentation: +flutter.dev/go/deep-link-flag-migration. + +Relevant PR: + +* [Set deep linking flag to true by defaulte][https://github.com/flutter/engine/pull/52350] + From 11fe254368d5af01f8ae4fd427b426dfd0d7588f Mon Sep 17 00:00:00 2001 From: hangyu Date: Fri, 13 Dec 2024 12:56:07 -0800 Subject: [PATCH 02/12] Update deep-links-flag-change.md --- src/content/release/breaking-changes/deep-links-flag-change.md | 1 - 1 file changed, 1 deletion(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index 1cc13a87bc6..e3c23ee0d76 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -1,6 +1,5 @@ --- title: Deep links flag change -description: >- --- From ac35e1962d65a28502e91ca9814e10351e22ccba Mon Sep 17 00:00:00 2001 From: hangyu Date: Fri, 13 Dec 2024 12:57:02 -0800 Subject: [PATCH 03/12] Update deep-links-flag-change.md --- src/content/release/breaking-changes/deep-links-flag-change.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index e3c23ee0d76..b374daaae70 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -10,7 +10,7 @@ The default value for Flutter’s deep linking flag has changed from false to tr ## Migration guide -If you’re using Flutter’s default deep linking setup, there’s no need to manually set the flag to true anymore. +If you’re using Flutter’s default deep linking setup, this is not a breaking change for you. However, if you’re using third-party plugins for deep links, such as: From b01c609b60e44a9766443c722ba81a84ef86a551 Mon Sep 17 00:00:00 2001 From: Hannah Jin Date: Fri, 13 Dec 2024 15:08:38 -0800 Subject: [PATCH 04/12] Update src/content/release/breaking-changes/deep-links-flag-change.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> --- .../release/breaking-changes/deep-links-flag-change.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index b374daaae70..dce2afe2192 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -5,7 +5,11 @@ title: Deep links flag change ## Summary -The default value for Flutter’s deep linking flag has changed from false to true, meaning deep linking is now opt-in by default. +This (potential) breaking change only affects mobile apps and only if you +use a third party deep linking plugin package. + +The default value for Flutter’s deep linking flag has changed from `false` to `true`, +meaning that deep linking is now opt-in by default. ## Migration guide From ab9c30c2b4ae6709e8ac79c0c0e3684f9ce473b5 Mon Sep 17 00:00:00 2001 From: Hannah Jin Date: Fri, 13 Dec 2024 15:08:44 -0800 Subject: [PATCH 05/12] Update src/content/release/breaking-changes/deep-links-flag-change.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> --- src/content/release/breaking-changes/deep-links-flag-change.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index dce2afe2192..3426ea8a510 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -21,7 +21,8 @@ However, if you’re using third-party plugins for deep links, such as: [firebase dynamic links][https://firebase.google.com/docs/dynamic-links] [uni_link][https://pub.dev/packages/uni_links] [app_links][https://pub.dev/packages/app_links] -This update will introduce a breaking change. In this case, you’ll need to manually reset the Flutter deep linking flag to false. + +In this case, you must manually reset the Flutter deep linking flag to `false`. Before: non-op From d228ce622306a8049ec98bf968ad125707fab968 Mon Sep 17 00:00:00 2001 From: Hannah Jin Date: Fri, 13 Dec 2024 15:08:50 -0800 Subject: [PATCH 06/12] Update src/content/release/breaking-changes/deep-links-flag-change.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> --- src/content/release/breaking-changes/deep-links-flag-change.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index 3426ea8a510..427ba9ee2f6 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -16,7 +16,8 @@ meaning that deep linking is now opt-in by default. If you’re using Flutter’s default deep linking setup, this is not a breaking change for you. -However, if you’re using third-party plugins for deep links, such as: +However, if you’re using a third-party plugin for deep links, +such as the following, this update introduces a breaking change: [firebase dynamic links][https://firebase.google.com/docs/dynamic-links] [uni_link][https://pub.dev/packages/uni_links] From 91d088269d1160a42715d9b9119b1e40d71c9615 Mon Sep 17 00:00:00 2001 From: Hannah Jin Date: Fri, 13 Dec 2024 15:08:56 -0800 Subject: [PATCH 07/12] Update src/content/release/breaking-changes/deep-links-flag-change.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> --- src/content/release/breaking-changes/deep-links-flag-change.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index 427ba9ee2f6..99cf76f3dc6 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -62,5 +62,5 @@ flutter.dev/go/deep-link-flag-migration. Relevant PR: -* [Set deep linking flag to true by defaulte][https://github.com/flutter/engine/pull/52350] +* [Set deep linking flag to true by defaulte]({{site.github}}/flutter/engine/pull/52350) From cca22de001e913bc1cb8d043834d03031ee2a90d Mon Sep 17 00:00:00 2001 From: Hannah Jin Date: Fri, 13 Dec 2024 15:09:02 -0800 Subject: [PATCH 08/12] Update src/content/release/breaking-changes/deep-links-flag-change.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> --- src/content/release/breaking-changes/deep-links-flag-change.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index 99cf76f3dc6..b3fb2e72e2b 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -29,7 +29,7 @@ Before: non-op After: -Manually disable the deep linking flag if you're using third-party plugins: +Manually disable the deep linking flag if you use a third-party plugin: * Android Manifest file From 58be5ca602cd7f3e605cb03a71522fbf580bf897 Mon Sep 17 00:00:00 2001 From: Hannah Jin Date: Fri, 13 Dec 2024 15:09:08 -0800 Subject: [PATCH 09/12] Update src/content/release/breaking-changes/deep-links-flag-change.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> --- .../release/breaking-changes/deep-links-flag-change.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index b3fb2e72e2b..c8fb8b78b47 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -1,6 +1,8 @@ --- title: Deep links flag change - +description: > + If you use a third party deep linking plugin package for mobile apps, + set Flutter's deep linking flag to false. --- ## Summary From 12c2974f1216901c2b7f6f1ba6eb8d1f1b1af778 Mon Sep 17 00:00:00 2001 From: hangyu Date: Fri, 13 Dec 2024 15:13:32 -0800 Subject: [PATCH 10/12] resolve comments --- .../release/breaking-changes/deep-links-flag-change.md | 4 ++-- src/content/release/breaking-changes/index.md | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index c8fb8b78b47..f46688c5d3a 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -35,7 +35,7 @@ Manually disable the deep linking flag if you use a third-party plugin: * Android Manifest file -```dart +```yaml @@ -47,7 +47,7 @@ Manually disable the deep linking flag if you use a third-party plugin: * iOS info.plist file -``` +```yaml FlutterDeepLinkingEnabled ``` diff --git a/src/content/release/breaking-changes/index.md b/src/content/release/breaking-changes/index.md index 61b464f1240..30af2f87f7e 100644 --- a/src/content/release/breaking-changes/index.md +++ b/src/content/release/breaking-changes/index.md @@ -54,6 +54,7 @@ release, and listed in alphabetical order: * [`Color` wide gamut support][] * [Remove invalid parameters for `InputDecoration.collapsed`][] * [Stop generating `AssetManifest.json`][] +* [Deep links flag change][] * [Deprecate `TextField.canRequestFocus`][] * [Set default for SystemUiMode to Edge-to-Edge][] * [Material 3 Tokens Update in Flutter][] @@ -62,6 +63,7 @@ release, and listed in alphabetical order: [`Color` wide gamut support]: /release/breaking-changes/wide-gamut-framework [Remove invalid parameters for `InputDecoration.collapsed`]: /release/breaking-changes/input-decoration-collapsed [Stop generating `AssetManifest.json`]: /release/breaking-changes/asset-manifest-dot-json +[Deep links flag change`]: /release/breaking-changes/deep-links-flag-change [Deprecate `TextField.canRequestFocus`]: /release/breaking-changes/can-request-focus [Set default for SystemUiMode to Edge-to-Edge]: /release/breaking-changes/default-systemuimode-edge-to-edge [Material 3 Tokens Update in Flutter]: /release/breaking-changes/material-design-3-token-update From 318a79200f28670390cdba41a2041d1debb0870b Mon Sep 17 00:00:00 2001 From: hangyu Date: Fri, 13 Dec 2024 15:31:06 -0800 Subject: [PATCH 11/12] Update index.md --- src/content/release/breaking-changes/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/release/breaking-changes/index.md b/src/content/release/breaking-changes/index.md index 30af2f87f7e..af3474e0fd6 100644 --- a/src/content/release/breaking-changes/index.md +++ b/src/content/release/breaking-changes/index.md @@ -63,7 +63,7 @@ release, and listed in alphabetical order: [`Color` wide gamut support]: /release/breaking-changes/wide-gamut-framework [Remove invalid parameters for `InputDecoration.collapsed`]: /release/breaking-changes/input-decoration-collapsed [Stop generating `AssetManifest.json`]: /release/breaking-changes/asset-manifest-dot-json -[Deep links flag change`]: /release/breaking-changes/deep-links-flag-change +[Deep links flag change]: /release/breaking-changes/deep-links-flag-change [Deprecate `TextField.canRequestFocus`]: /release/breaking-changes/can-request-focus [Set default for SystemUiMode to Edge-to-Edge]: /release/breaking-changes/default-systemuimode-edge-to-edge [Material 3 Tokens Update in Flutter]: /release/breaking-changes/material-design-3-token-update From 0687357c34f9c6fcf06a2913ec5785dac3d68094 Mon Sep 17 00:00:00 2001 From: "Shams Zakhour (ignore Sfshaza)" <44418985+sfshaza2@users.noreply.github.com> Date: Sat, 14 Dec 2024 10:16:55 -0800 Subject: [PATCH 12/12] Update src/content/release/breaking-changes/deep-links-flag-change.md --- .../release/breaking-changes/deep-links-flag-change.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/content/release/breaking-changes/deep-links-flag-change.md b/src/content/release/breaking-changes/deep-links-flag-change.md index f46688c5d3a..39ab6d38d56 100644 --- a/src/content/release/breaking-changes/deep-links-flag-change.md +++ b/src/content/release/breaking-changes/deep-links-flag-change.md @@ -21,9 +21,9 @@ If you’re using Flutter’s default deep linking setup, this is not a breaking However, if you’re using a third-party plugin for deep links, such as the following, this update introduces a breaking change: -[firebase dynamic links][https://firebase.google.com/docs/dynamic-links] -[uni_link][https://pub.dev/packages/uni_links] -[app_links][https://pub.dev/packages/app_links] +[firebase dynamic links](https://firebase.google.com/docs/dynamic-links) +[uni_link](https://pub.dev/packages/uni_links) +[app_links](https://pub.dev/packages/app_links) In this case, you must manually reset the Flutter deep linking flag to `false`.