This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Revert AndroidX changes for 1.0.0 plugins - #1127
Merged
Merged
Conversation
The AndroidX migration didn't increment the major version for plugins >= 1.0.0. This commit reverts the code changes in the affected plugins.
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
The AndroidX migration didn't increment the major version for plugins >= 1.0.0. This commit reverts the code changes in the affected plugins. It's critical that the forward roll PR is published with this so that clients that have previously migrated aren't broken by the revert. I'm not planning on merging this into master until the forward roll (flutter-team-archive#1128) is also LGTMed and ready to merge. flutter/flutter#27128 flutter/flutter#23995
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
The AndroidX migration didn't increment the major version for plugins >= 1.0.0. This commit reverts the code changes in the affected plugins. It's critical that the forward roll PR is published with this so that clients that have previously migrated aren't broken by the revert. I'm not planning on merging this into master until the forward roll (flutter-team-archive#1128) is also LGTMed and ready to merge. flutter/flutter#27128 flutter/flutter#23995
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AndroidX migration didn't increment the major version for plugins >=
1.0.0. This reverts it in a patch, forward roll with a major update to follow in
a separate PR.
It's critical that the forward roll PR is published with this so that clients
that have previously migrated aren't broken by the revert. I'm not planning
on merging this into master until the forward roll (#1128) is
also LGTMed and ready to merge.