update tests

Author: thanhdatvo

packages/android_intent/lib/android_intent.dart

@@ -36,6 +36,20 @@ class AndroidIntent {
         _channel = const MethodChannel(kChannelName),
         _platform = platform ?? const LocalPlatform();
 
+  @visibleForTesting
+  AndroidIntent.private({
+    @required this.action,
+    @required Platform platform,
+    @required MethodChannel channel,
+    this.flags,
+    this.category,
+    this.data,
+    this.arguments,
+    this.package,
+    this.componentName,
+  })  : _channel = channel,
+        _platform = platform;
+
   final String action;
   final List<int> flags;
   final String category;
@@ -65,10 +79,11 @@ class AndroidIntent {
 
   /// Launch the intent.
   ///
-  /// This works only on Android platforms. Please guard the call so that your
-  /// iOS app does not crash. Checked mode will throw an assert exception.
+  /// This works only on Android platforms.
   Future<void> launch() async {
-    assert(_platform.isAndroid);
+    if (!_platform.isAndroid) {
+      return;
+    }
     final Map<String, dynamic> args = <String, dynamic>{'action': action};
     if (flags != null) {
       args['flags'] = convertFlags(flags);

packages/android_intent/pubspec.yaml

@@ -2,7 +2,7 @@ name: android_intent
 description: Flutter plugin for launching Android Intents. Not supported on iOS.
 author: Flutter Team <[email protected]>
 homepage: https://github.com/flutter/plugins/tree/master/packages/android_intent
-version: 0.3.2
+version: 0.3.3
 
 flutter:
   plugin:
@@ -15,6 +15,9 @@ dependencies:
     sdk: flutter
   platform: ^2.0.0
   meta: ^1.0.5
+dev_dependencies:
+  test: ^1.3.0
+  mockito: ^3.0.0
   flutter_test:
     sdk: flutter
 environment:

packages/android_intent/test/android_intent_test.dart

@@ -2,68 +2,56 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import 'dart:io';
-
 import 'package:android_intent/flag.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:android_intent/android_intent.dart';
+import 'package:mockito/mockito.dart';
+import 'package:platform/platform.dart';
 
 void main() {
   AndroidIntent androidIntent;
-  const MethodChannel channel =
-      MethodChannel('plugins.flutter.io/android_intent');
-  final List<MethodCall> log = <MethodCall>[];
+  MockMethodChannel mockChannel;
   setUp(() {
-    channel.setMockMethodCallHandler((MethodCall methodCall) async {
-      log.add(methodCall);
-      return '';
-    });
-    log.clear();
+    mockChannel = MockMethodChannel();
   });
   group('AndroidIntent', () {
     test('pass right params', () async {
-      if (Platform.isIOS) {
-      } else if (Platform.isAndroid) {
-        androidIntent = AndroidIntent(
+      androidIntent = AndroidIntent.private(
           action: 'action_view',
           data: Uri.encodeFull('https://flutter.io'),
           flags: <int>[Flag.FLAG_ACTIVITY_NEW_TASK],
-        );
-        androidIntent.launch();
-        expect(
-          log,
-          <Matcher>[
-            isMethodCall('launch', arguments: <String, Object>{
-              'action': 'action_view',
-              'data': Uri.encodeFull('https://flutter.io'),
-              'flags': androidIntent
-                  .convertFlags(<int>[Flag.FLAG_ACTIVITY_NEW_TASK]),
-            })
-          ],
-        );
-      }
+          channel: mockChannel,
+          platform: FakePlatform(operatingSystem: 'android'));
+      androidIntent.launch();
+      verify(mockChannel.invokeMethod<void>('launch', <String, Object>{
+        'action': 'action_view',
+        'data': Uri.encodeFull('https://flutter.io'),
+        'flags': androidIntent.convertFlags(<int>[Flag.FLAG_ACTIVITY_NEW_TASK]),
+      }));
+    });
+    test('pass null value to action param', () async {
+      androidIntent = AndroidIntent.private(
+          action: null,
+          channel: mockChannel,
+          platform: FakePlatform(operatingSystem: 'android'));
+      androidIntent.launch();
+      verify(mockChannel.invokeMethod<void>('launch', <String, Object>{
+        'action': null,
+      }));
     });
-    test('pass wrong params', () async {
-      if (Platform.isIOS) {
-      } else if (Platform.isAndroid) {
-        androidIntent = AndroidIntent(
+
+    test('call in ios platform', () async {
+      androidIntent = AndroidIntent.private(
           action: null,
-        );
-        androidIntent.launch();
-        expect(
-          log,
-          <Matcher>[
-            isMethodCall('launch', arguments: <String, Object>{
-              'action': null,
-            })
-          ],
-        );
-      }
+          channel: mockChannel,
+          platform: FakePlatform(operatingSystem: 'ios'));
+      androidIntent.launch();
+      verifyZeroInteractions(mockChannel);
     });
   });
-  group('Flags: ', () {
-    androidIntent = AndroidIntent(
+  group('convertFlags ', () {
+    androidIntent = const AndroidIntent(
       action: 'action_view',
     );
     test('add filled flag list', () async {
@@ -93,3 +81,5 @@ void main() {
     });
   });
 }
+
+class MockMethodChannel extends Mock implements MethodChannel {}