Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 8c8bec0

Browse files
KlausJokisuoiskakaushik
authored andcommitted
[google_maps] Set correct polyline width when building polylines. (#1935)
* Fix polyline width when created by adding density option to PolyLineBuilder class * Version bump * Adjust changelog
1 parent 230c53f commit 8c8bec0

4 files changed

Lines changed: 10 additions & 4 deletions

File tree

packages/google_maps_flutter/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.5.20+2
2+
3+
* Android: Fix polyline width in building phase.
4+
15
## 0.5.20+1
26

37
* Android: Unregister ActivityLifecycleCallbacks on activity destroy (fixes a memory leak).

packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylineBuilder.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@
99
class PolylineBuilder implements PolylineOptionsSink {
1010
private final PolylineOptions polylineOptions;
1111
private boolean consumeTapEvents;
12+
private final float density;
1213

13-
PolylineBuilder() {
14+
PolylineBuilder(float density) {
1415
this.polylineOptions = new PolylineOptions();
16+
this.density = density;
1517
}
1618

1719
PolylineOptions build() {
@@ -70,7 +72,7 @@ public void setVisible(boolean visible) {
7072

7173
@Override
7274
public void setWidth(float width) {
73-
polylineOptions.width(width);
75+
polylineOptions.width(width * density);
7476
}
7577

7678
@Override

packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylinesController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ private void addPolyline(Object polyline) {
8181
if (polyline == null) {
8282
return;
8383
}
84-
PolylineBuilder polylineBuilder = new PolylineBuilder();
84+
PolylineBuilder polylineBuilder = new PolylineBuilder(density);
8585
String polylineId = Convert.interpretPolylineOptions(polyline, polylineBuilder);
8686
PolylineOptions options = polylineBuilder.build();
8787
addPolyline(polylineId, options, polylineBuilder.consumeTapEvents());

packages/google_maps_flutter/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: google_maps_flutter
22
description: A Flutter plugin for integrating Google Maps in iOS and Android applications.
33
author: Flutter Team <flutter-dev@googlegroups.com>
44
homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter
5-
version: 0.5.20+1
5+
version: 0.5.20+2
66

77
dependencies:
88
flutter:

0 commit comments

Comments
 (0)