Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 7087d49

Browse files
committed
Link issue to split mocking better.
1 parent 908beac commit 7087d49

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

packages/google_sign_in/google_sign_in_web/lib/src/gis_client.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,11 @@
33
// found in the LICENSE file.
44
import 'dart:async';
55

6-
// TODO(dit): A better layer to split this would be to make a mockable client that
7-
// exposes only the APIs we need from gis_web/id.dart and gis_web/oauth2.dart.
8-
// That way, the GisSdkClient class would be testable (and the mock surface would
9-
// only deal with the few methods we actually use from the SDK). Next version.
6+
// TODO(dit): Split `id` and `oauth2` "services" for mocking. https://github.com/flutter/flutter/issues/120657
107
import 'package:google_identity_services_web/id.dart';
118
import 'package:google_identity_services_web/oauth2.dart';
129
import 'package:google_sign_in_platform_interface/google_sign_in_platform_interface.dart';
10+
// ignore: unnecessary_import
1311
import 'package:js/js.dart';
1412
import 'package:js/js_util.dart';
1513

0 commit comments

Comments
 (0)