[local_auth] Fixed auth PR reviews.

Author: karan-rawal

packages/local_auth/CHANGELOG.md

@@ -1,4 +1,4 @@
-## 0.6.0+3
+## 0.6.1
 
 * Added ability to stop authentication (For Android).
 

packages/local_auth/android/src/main/java/io/flutter/plugins/localauth/LocalAuthPlugin.java

@@ -38,7 +38,7 @@ private LocalAuthPlugin(Registrar registrar) {
   @Override
   public void onMethodCall(MethodCall call, final Result result) {
     if (call.method.equals("authenticateWithBiometrics")) {
-      if (!authInProgress.compareAndSet(false, true)) {
+      if (authInProgress.get()) {
         // Apps should not invoke another authentication request while one is in progress,
         // so we classify this as an error condition. If we ever find a legitimate use case for
         // this, we can try to cancel the ongoing auth and start a new one but for now, not worth
@@ -60,6 +60,7 @@ public void onMethodCall(MethodCall call, final Result result) {
             null);
         return;
       }
+      authInProgress.set(true);
       authenticationHelper =
           new AuthenticationHelper(
               (FragmentActivity) activity,

packages/local_auth/lib/local_auth.dart

@@ -91,16 +91,15 @@ class LocalAuthentication {
   }
 
   /// Returns true if auth was cancelled successfully.
+  /// This api only works for Android.
   /// Returns false if there was some error or no auth in progress.
   ///
   /// Returns [Future] bool true or false:
   Future<bool> stopAuthentication() {
     if (_platform.isAndroid) {
       return _channel.invokeMethod<bool>('stopAuthentication');
     }
-    final Future<bool> future = Future<bool>(() => true);
-    Completer<bool>().complete(future);
-    return future;
+    return Future<bool>.sync(() => true);
   }
 
   /// Returns true if device is capable of checking biometrics

packages/local_auth/pubspec.yaml

@@ -3,7 +3,7 @@ description: Flutter plugin for Android and iOS device authentication sensors
   such as Fingerprint Reader and Touch ID.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/local_auth
-version: 0.6.0+3
+version: 0.6.1
 
 flutter:
   plugin:
@@ -16,7 +16,7 @@ dependencies:
     sdk: flutter
   meta: ^1.0.5
   intl: ">=0.15.1 <0.17.0"
-  platform: ^2.0.0 
+  platform: ^2.0.0
 
 dev_dependencies:
   flutter_test: