Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 18b3cdd

Browse files
강동윤kroikie
authored andcommitted
Remove a wrong assertion. (#665)
* Remove a wrong assertion. Google play games service does not give us displayName. Closes flutter/flutter#19442
1 parent 9f80468 commit 18b3cdd

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

packages/google_sign_in/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 3.0.6
2+
3+
* Remove flaky displayName assertion
4+
15
## 3.0.5
26

37
* Added missing http package dependency.

packages/google_sign_in/lib/google_sign_in.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ class GoogleSignInAccount implements GoogleIdentity {
3737
id = data['id'],
3838
photoUrl = data['photoUrl'],
3939
_idToken = data['idToken'] {
40-
assert(displayName != null);
4140
assert(id != null);
4241
}
4342

packages/google_sign_in/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for Google Sign-In, a secure authentication system
33
for signing in with a Google account on Android and iOS.
44
author: Flutter Team <[email protected]>
55
homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in
6-
version: 3.0.5
6+
version: 3.0.6
77

88
flutter:
99
plugin:

0 commit comments

Comments
 (0)