Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 0d3b3f7

Browse files
author
hffmnn
committed
update to new API
1 parent 9e25d82 commit 0d3b3f7

2 files changed

Lines changed: 12 additions & 9 deletions

File tree

packages/firebase_crashlytics/lib/src/firebase_crashlytics.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ class Crashlytics {
2525
MethodChannel('plugins.flutter.io/firebase_crashlytics');
2626

2727
/// Submits non-fatal crash report to Firebase Crashlytics.
28-
Future<void> onError(FlutterErrorDetails details) async {
29-
print('Error caught by Crashlytics plugin:');
28+
Future<void> recordFlutterError(FlutterErrorDetails details) async {
29+
print('Error caught by Crashlytics plugin <recordFlutterError>:');
3030

3131
bool inDebugMode = false;
3232
if (!enableInDevMode) {
@@ -55,8 +55,9 @@ class Crashlytics {
5555
}
5656
}
5757

58-
Future<void> onRuntimeException(dynamic exception, dynamic stack) async {
59-
print('Runtime Exception caught by Crashlytics plugin:');
58+
Future<void> recordError(dynamic exception, StackTrace stack,
59+
{dynamic context}) async {
60+
print('Error caught by Crashlytics plugin <recordError>:');
6061

6162
bool inDebugMode = false;
6263
if (!enableInDevMode) {
@@ -74,6 +75,7 @@ class Crashlytics {
7475
final dynamic result = await channel
7576
.invokeMethod<dynamic>('Crashlytics#onError', <String, dynamic>{
7677
'exception': "${exception.toString()}",
78+
'context': '$context',
7779
'stackTraceElements': stackTraceElements,
7880
'logs': _logs.toList(),
7981
'keys': _prepareKeys(),

packages/firebase_crashlytics/test/firebase_crashlytics_test.dart

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void main() {
3333
log.clear();
3434
});
3535

36-
test('onError', () async {
36+
test('recordFlutterError', () async {
3737
final FlutterErrorDetails details = FlutterErrorDetails(
3838
exception: 'foo exception',
3939
stack: StackTrace.current,
@@ -46,7 +46,7 @@ void main() {
4646
crashlytics.setInt('testInt', 42);
4747
crashlytics.setDouble('testDouble', 42.0);
4848
crashlytics.setString('testString', 'bar');
49-
await crashlytics.onError(details);
49+
await crashlytics.recordFlutterError(details);
5050
expect(log[0].method, 'Crashlytics#onError');
5151
expect(log[0].arguments['exception'], 'foo exception');
5252
expect(log[0].arguments['context'], 'foo context');
@@ -66,13 +66,14 @@ void main() {
6666
expect(log[0].arguments['keys'][3]['type'], 'string');
6767
});
6868

69-
test('onRuntimeException', () async {
69+
test('recordError', () async {
7070
crashlytics.enableInDevMode = true;
7171
crashlytics.log('foo');
72-
await crashlytics.onRuntimeException('foo exception', StackTrace.current);
72+
await crashlytics.recordError('foo exception', StackTrace.current,
73+
context: "context");
7374
expect(log[0].method, 'Crashlytics#onError');
7475
expect(log[0].arguments['exception'], 'foo exception');
75-
expect(log[0].arguments['context'], null);
76+
expect(log[0].arguments['context'], "context");
7677
expect(log[0].arguments['logs'], isNotEmpty);
7778
expect(log[0].arguments['logs'], contains('foo'));
7879
expect(log[0].arguments['keys'][0]['key'], 'testBool');

0 commit comments

Comments
 (0)