From 4b867bb79324dbc2e1de17714f3101034e5541de Mon Sep 17 00:00:00 2001 From: LongCat is Looong <31859944+LongCatIsLooong@users.noreply.github.com> Date: Fri, 16 Jun 2023 18:55:43 -0700 Subject: [PATCH 1/2] Add missing ignores for textScaleFactor deprecation --- packages/flutter_markdown/lib/src/builder.dart | 8 ++++---- .../test/text_scale_factor_test.dart | 15 +++++++-------- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/packages/flutter_markdown/lib/src/builder.dart b/packages/flutter_markdown/lib/src/builder.dart index b688427e8cdd..f32ec0a19f03 100644 --- a/packages/flutter_markdown/lib/src/builder.dart +++ b/packages/flutter_markdown/lib/src/builder.dart @@ -829,8 +829,8 @@ class MarkdownBuilder implements md.NodeVisitor { if (selectable) { return SelectableText.rich( text!, - textScaleFactor: - styleSheet.textScaleFactor, // ignore: deprecated_member_use + // ignore: deprecated_member_use + textScaleFactor: styleSheet.textScaleFactor, textAlign: textAlign ?? TextAlign.start, onTap: onTapText, key: k, @@ -838,8 +838,8 @@ class MarkdownBuilder implements md.NodeVisitor { } else { return RichText( text: text!, - textScaleFactor: - styleSheet.textScaleFactor!, // ignore: deprecated_member_use + // ignore: deprecated_member_use + textScaleFactor: styleSheet.textScaleFactor!, textAlign: textAlign ?? TextAlign.start, key: k, ); diff --git a/packages/flutter_markdown/test/text_scale_factor_test.dart b/packages/flutter_markdown/test/text_scale_factor_test.dart index 41b5ec7c9beb..9889ab06b581 100644 --- a/packages/flutter_markdown/test/text_scale_factor_test.dart +++ b/packages/flutter_markdown/test/text_scale_factor_test.dart @@ -36,8 +36,8 @@ void defineTests() { await tester.pumpWidget( boilerplate( const MediaQuery( - data: MediaQueryData( - textScaleFactor: 2.0), // ignore: deprecated_member_use + // ignore: deprecated_member_use + data: MediaQueryData(textScaleFactor: 2.0), child: MarkdownBody( data: data, ), @@ -57,8 +57,8 @@ void defineTests() { await tester.pumpWidget( boilerplate( const MediaQuery( - data: MediaQueryData( - textScaleFactor: 2.0), // ignore: deprecated_member_use + // ignore: deprecated_member_use + data: MediaQueryData(textScaleFactor: 2.0), child: MarkdownBody( data: data, selectable: true, @@ -67,10 +67,9 @@ void defineTests() { ), ); - final SelectableText selectableText = - tester.widget(find.byType(SelectableText)); - expect(selectableText.textScaleFactor, - 2.0); // ignore: deprecated_member_use + final SelectableText selectableText = tester.widget(find.byType(SelectableText)); + // ignore: deprecated_member_use + expect(selectableText.textScaleFactor, 2.0); }, ); }); From 191fadd59dc8a4616b96cd4d8cd47df028712a51 Mon Sep 17 00:00:00 2001 From: LongCat is Looong <31859944+LongCatIsLooong@users.noreply.github.com> Date: Fri, 16 Jun 2023 19:05:41 -0700 Subject: [PATCH 2/2] format --- packages/flutter_markdown/test/text_scale_factor_test.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/flutter_markdown/test/text_scale_factor_test.dart b/packages/flutter_markdown/test/text_scale_factor_test.dart index 9889ab06b581..2f3138a94aef 100644 --- a/packages/flutter_markdown/test/text_scale_factor_test.dart +++ b/packages/flutter_markdown/test/text_scale_factor_test.dart @@ -67,7 +67,8 @@ void defineTests() { ), ); - final SelectableText selectableText = tester.widget(find.byType(SelectableText)); + final SelectableText selectableText = + tester.widget(find.byType(SelectableText)); // ignore: deprecated_member_use expect(selectableText.textScaleFactor, 2.0); },