You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[image_picker] Remove use of Pigeon's Dart test generator (#10320)
Updates `image_picker_ios` to use the same test structure that `image_picker_android` already uses:
- Removes the use of Pigeon's Dart test generator in favor of DI'ing an implementation of the actual generated Dart API.
- Removes the use of the old method channel logger (which was adapted in place during the Pigeon conversion to minimize test changes in the PR that changed the implementation; the fact that it was still being used was tech debt), in favor of structured storage of passed arguments that can be queried directly. This makes tests much shorter and easier to understand and maintain, because if we want to check one parameter in a targeted test, we don't have to assert the entire argument dictionary.
- Adds some missing test functionality (e.g., we didn't have tests of any of the non-null return value handling), and removes some duplicate testing (e.g., every possible combination of null and non-null width, hight, and image quality in on giant test).
Also does minor cleanup of `image_picker_android`; this conversion had already been done there, but it was still generating an unused `dartTestOut`.
Part of flutter/flutter#159886
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
0 commit comments