Skip to content

Commit 6ae22ef

Browse files
authored
Fix detection that tests are running on monorepo bots (#129173)
Automatic CI testing runs on monorepo bots that tests the heads of the Dart SDK, Flutter engine, and Flutter framework together. These tests previously ran on bots called HHH (triple-headed), and the logic for detecting this used the machine name of the test machine. Extend that detection logic to cover the test machine hostnames that run monorepo testing, that start with either 'dart-tests-' or 'luci-dart-'. None of the machines used to run Flutter release builds have names like this, even though they are in an internal Dart luci project. Bug: b/231927187
1 parent 3291750 commit 6ae22ef

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

dev/bots/test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,8 @@ Future<void> main(List<String> args) async {
277277
}
278278

279279
final String _luciBotId = Platform.environment['SWARMING_BOT_ID'] ?? '';
280-
final bool _runningInDartHHHBot = _luciBotId.startsWith('luci-dart-');
280+
final bool _runningInDartHHHBot =
281+
_luciBotId.startsWith('luci-dart-') || _luciBotId.startsWith('dart-tests-');
281282

282283
/// Verify the Flutter Engine is the revision in
283284
/// bin/cache/internal/engine.version.

0 commit comments

Comments
 (0)