Fixes feedback

Author: HugoOlthof

packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md

@@ -28,11 +28,6 @@
 
 ## 3.2.0
 
-* Updates minimum Flutter version to 3.3 and iOS 11.
-* Aligns Dart and Flutter SDK constraints.
-
-## 3.2.0
-
 * Updates minimum Flutter version to 3.3 and iOS 11.
 
 ## 3.1.1

packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFDataConverters.h

@@ -110,7 +110,7 @@ extern FWFNSUrlRequestData *FWFNSUrlRequestDataFromNSURLRequest(NSURLRequest *re
  *
  * @return A FWFWKNavigationResponseData.
  */
-extern FWFWKNavigationResponseData *FWFWKNavigationResponseDataFromNavigationResponse(
+extern FWFWKNavigationResponseData *FWFWKNavigationResponseDataFromNativeNavigationResponse(
     WKNavigationResponse *response);
 /**
  * Converts a NSURLResponse to an FWFNSHttpUrlResponseData.
@@ -119,7 +119,8 @@ extern FWFWKNavigationResponseData *FWFWKNavigationResponseDataFromNavigationRes
  *
  * @return A FWFNSHttpUrlResponseData.
  */
-extern FWFNSHttpUrlResponseData *FWFNSHttpUrlResponseDataFromNSURLResponse(NSURLResponse *response);
+extern FWFNSHttpUrlResponseData *FWFNSHttpUrlResponseDataFromNativeNSURLResponse(
+    NSURLResponse *response);
 
 /**
  * Converts a WKFrameInfo to an FWFWKFrameInfoData.
@@ -147,7 +148,7 @@ extern WKNavigationActionPolicy FWFWKNavigationActionPolicyFromEnumData(
  *
  * @return A WKNavigationResponsePolicy or -1 if data could not be converted.
  */
-extern WKNavigationResponsePolicy FWFWKNavigationResponsePolicyFromEnumData(
+extern WKNavigationResponsePolicy FWFNativeWKNavigationResponsePolicyFromEnumData(
     FWFWKNavigationResponsePolicyEnumData *data);
 
 /**

packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFDataConverters.m

@@ -175,10 +175,10 @@ WKAudiovisualMediaTypes FWFWKAudiovisualMediaTypeFromEnumData(
       allHttpHeaderFields:request.allHTTPHeaderFields ? request.allHTTPHeaderFields : @{}];
 }
 
-FWFWKNavigationResponseData *FWFWKNavigationResponseDataFromNavigationResponse(
+FWFWKNavigationResponseData *FWFWKNavigationResponseDataFromNativeNavigationResponse(
     WKNavigationResponse *response) {
   return [FWFWKNavigationResponseData
-      makeWithResponse:FWFNSHttpUrlResponseDataFromNSURLResponse(response.response)
+      makeWithResponse:FWFNSHttpUrlResponseDataFromNativeNSURLResponse(response.response)
           forMainFrame:@(response.forMainFrame)];
 }
 
@@ -188,7 +188,7 @@ WKAudiovisualMediaTypes FWFWKAudiovisualMediaTypeFromEnumData(
 /// This cast will always succeed because the NSURLResponse object actually is an instance of
 /// NSHTTPURLResponse. See:
 /// https://developer.apple.com/documentation/foundation/nsurlresponse#overview
-FWFNSHttpUrlResponseData *FWFNSHttpUrlResponseDataFromNSURLResponse(NSURLResponse *response) {
+FWFNSHttpUrlResponseData *FWFNSHttpUrlResponseDataFromNativeNSURLResponse(NSURLResponse *response) {
   NSHTTPURLResponse *httpResponse = (NSHTTPURLResponse *)response;
   return [FWFNSHttpUrlResponseData makeWithStatusCode:@(httpResponse.statusCode)];
 }
@@ -209,7 +209,7 @@ WKNavigationActionPolicy FWFWKNavigationActionPolicyFromEnumData(
   return -1;
 }
 
-WKNavigationResponsePolicy FWFWKNavigationResponsePolicyFromEnumData(
+WKNavigationResponsePolicy FWFNativeWKNavigationResponsePolicyFromEnumData(
     FWFWKNavigationResponsePolicyEnumData *data) {
   switch (data.value) {
     case FWFWKNavigationResponsePolicyEnumAllow:

packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFNavigationDelegateHostApi.m

@@ -79,7 +79,7 @@ - (void)decidePolicyForNavigationResponseForDelegate:(FWFNavigationDelegate *)in
   NSNumber *webViewIdentifier =
       @([self.instanceManager identifierWithStrongReferenceForInstance:webView]);
   FWFWKNavigationResponseData *navigationResponseData =
-      FWFWKNavigationResponseDataFromNavigationResponse(navigationResponse);
+      FWFWKNavigationResponseDataFromNativeNavigationResponse(navigationResponse);
   [self decidePolicyForNavigationResponseForDelegateWithIdentifier:
             @([self identifierForDelegate:instance])
                                                  webViewIdentifier:webViewIdentifier
@@ -181,7 +181,8 @@ - (void)webView:(WKWebView *)webView
                                                      FlutterError *error) {
                                           NSAssert(!error, @"%@", error);
                                           decisionHandler(
-                                              FWFWKNavigationResponsePolicyFromEnumData(policy));
+                                              FWFNativeWKNavigationResponsePolicyFromEnumData(
+                                                  policy));
                                         }];
 }