This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove SkOSLibrary files from build and license scripts#54583
Merged
Conversation
These are no longer under the `src/ports` directory in Skia and are in `tools/`. But it appears that Flutter does not actually require them.
brianosman
approved these changes
Aug 16, 2024
brianosman
approved these changes
Aug 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 16, 2024
flutter-team-archive/engine@b66893e...acb71d8 2024-08-16 lhkbob@gmail.com Remove SkOSLibrary files from build and license scripts (flutter-team-archive/engine#54583) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
) flutter-team-archive/engine@b66893e...acb71d8 2024-08-16 lhkbob@gmail.com Remove SkOSLibrary files from build and license scripts (flutter-team-archive/engine#54583) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are no longer under the
src/portsdirectory in Skia and are intools/. But it appears that Flutter does not actually quire them.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.