From 25b289d8407a9c3c719114cf29b5bb3d8df86fef Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Wed, 7 Jun 2023 09:31:38 -0700 Subject: [PATCH 1/5] Benchmarks configurations for engine v2. This configuration migrates benchmarks to engine_v2. --- ci/builders/standalone/linux_benchmarks.json | 51 ++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 ci/builders/standalone/linux_benchmarks.json diff --git a/ci/builders/standalone/linux_benchmarks.json b/ci/builders/standalone/linux_benchmarks.json new file mode 100644 index 0000000000000..3bbe65527cd49 --- /dev/null +++ b/ci/builders/standalone/linux_benchmarks.json @@ -0,0 +1,51 @@ +{ + "drone_dimensions": [ + "device_type=none", + "os=Linux" + ], + "gclient_variables": { + "download_android_deps": false + }, + "gn": [ + "--runtime-mode", + "release", + "--prebuilt-dart-sdk", + "--build-embedder-examples" + ], + "name": "host_release", + "ninja": { + "config": "host_release", + "targets": [ + "flutter/build/dart:copy_dart_sdk", + "flutter/display_list:display_list_benchmarks", + "flutter/display_list:display_list_builder_benchmarks", + "flutter/fml:fml_benchmarks", + "flutter/impeller/geometry:geometry_benchmarks", + "flutter/lib/ui:ui_benchmarks", + "flutter/shell/common:shell_benchmarks", + "flutter/shell/testing", + "flutter/third_party/txt:txt_benchmarks", + "flutter/tools/path_ops", + "flutter/build/archives:flutter_patched_sdk", + "flutter:unittests" + ] + }, + "tests": [ + { + "language": "bash", + "name": "Generate metrics test", + "script": "flutter/testing/benchmark/generate_metrics.sh" + }, + { + "contexts": [ + "metric_center_token" + ], + "language": "bash", + "name": "Upload metrics dry-run", + "parameters": [ + "--upload" + ], + "script": "flutter/testing/benchmark/upload_metrics.sh" + } + ] +} From 7b8d76a907885ad31e97a2ad9aee06da57d03d67 Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Wed, 7 Jun 2023 11:47:52 -0700 Subject: [PATCH 2/5] Remove --noupload flag. --- ci/builders/standalone/linux_benchmarks.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ci/builders/standalone/linux_benchmarks.json b/ci/builders/standalone/linux_benchmarks.json index 3bbe65527cd49..fdec72e47ae7a 100644 --- a/ci/builders/standalone/linux_benchmarks.json +++ b/ci/builders/standalone/linux_benchmarks.json @@ -41,10 +41,7 @@ "metric_center_token" ], "language": "bash", - "name": "Upload metrics dry-run", - "parameters": [ - "--upload" - ], + "name": "Upload metrics", "script": "flutter/testing/benchmark/upload_metrics.sh" } ] From a4fe8f208c1fd4f865bc82f80bc4db80ee41cf22 Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Wed, 7 Jun 2023 12:17:00 -0700 Subject: [PATCH 3/5] Add builder. --- .ci.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.ci.yaml b/.ci.yaml index 03de8ce0aefb9..39684d9ee1329 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -194,6 +194,15 @@ targets: upload_metrics: "true" timeout: 60 + - name: Linux linux_benchmarks + enabled_branches: + - main + recipe: engine_v2/builder + presubmit: false + properties: + config_name: linux_fuchsia + timeout: 60 + - name: Linux Benchmarks (no-upload) recipe: engine/engine_metrics bringup: true From aabfc0c781dda6a4b1e40b009b7c81d9107a4438 Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Wed, 7 Jun 2023 15:44:17 -0700 Subject: [PATCH 4/5] Use correct config name. --- .ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci.yaml b/.ci.yaml index 39684d9ee1329..0683e1909f16f 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -200,7 +200,7 @@ targets: recipe: engine_v2/builder presubmit: false properties: - config_name: linux_fuchsia + config_name: linux_benchmarks timeout: 60 - name: Linux Benchmarks (no-upload) From c51c6d644833ac6abbd9ad51b02d0a8075c297dd Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Wed, 7 Jun 2023 15:46:43 -0700 Subject: [PATCH 5/5] Add builder as bringup. --- .ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.ci.yaml b/.ci.yaml index 0683e1909f16f..b0d52adbc9a8a 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -195,6 +195,7 @@ targets: timeout: 60 - name: Linux linux_benchmarks + bringup: true enabled_branches: - main recipe: engine_v2/builder