review comments followup

Author: amirh

shell/platform/darwin/ios/framework/Headers/FlutterPlatformViews.h

@@ -5,51 +5,32 @@
 #ifndef FLUTTER_FLUTTERPLATFORMVIEWS_H_
 #define FLUTTER_FLUTTERPLATFORMVIEWS_H_
 
-#import <CoreMedia/CoreMedia.h>
-#import <Foundation/Foundation.h>
 #import <UIKit/UIKit.h>
 
-#include "FlutterCodecs.h"
-#include "FlutterMacros.h"
+#import "FlutterCodecs.h"
+#import "FlutterMacros.h"
 
 NS_ASSUME_NONNULL_BEGIN
 
-/**
- * An instance of a `UIView` created by a `FlutterPlatformViewFactory`.
- *
- * This protocol is used to associate a view with a dispose callback.
- */
-FLUTTER_EXPORT
-@protocol FlutterPlatformView <NSObject>
-- (UIView*)view;
-/**
- * Called when the Flutter engine no longer needs this `view`.
- *
- * The implementation of this method should release any kept for this view.
- */
-- (void)dispose;
-@end
-
 FLUTTER_EXPORT
 @protocol FlutterPlatformViewFactory <NSObject>
 /**
  * Create a `FlutterPlatformView`.
  *
  * Implemented by iOS code that expose a `UIView` for embedding in a Flutter app.
  *
- * The implementation of this method should create a new `UIView` and return a `FlutterPlatformView`
- * that wraps it.
+ * The implementation of this method should create a new `UIView` and return it.
  *
  * @param frame The rectangle for the newly created `UIView` measued in points.
- * @param viewId A unique identifier for this `UIView`.
- * @param args Parameters for creating the `UIView` sent from the Dart side of the Flutter app.
+ * @param viewIdentifier A unique identifier for this `UIView`.
+ * @param arguments Parameters for creating the `UIView` sent from the Dart side of the Flutter app.
  *   If `createArgsCodec` is not implemented, or if no creation arguments were sent from the Dart
  *   code, this will be null. Otherwise this will be the value sent from the Dart code as decoded by
  *   `createArgsCodec`.
  */
-- (NSObject<FlutterPlatformView>*)createWithFrame:(CGRect)frame
-                                           viewId:(int64_t)viewId
-                                          andArgs:(id _Nullable)args;
+- (UIView*)createWithFrame:(CGRect)frame
+            viewIdentifier:(int64_t)viewId
+                 arguments:(id _Nullable)args;
 
 /**
  * Returns the `FlutterMessageCodec` for decoding the args parameter of `createWithFrame`.

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

@@ -55,10 +55,9 @@
   }
 
   // TODO(amirh): decode and pass the creation args.
-  views_[viewId] =
-      fml::scoped_nsobject<NSObject<FlutterPlatformView>>([[factory createWithFrame:CGRectZero
-                                                                             viewId:viewId
-                                                                            andArgs:nil] retain]);
+  views_[viewId] = fml::scoped_nsobject<UIView>([[factory createWithFrame:CGRectZero
+                                                           viewIdentifier:viewId
+                                                                arguments:nil] retain]);
   result(nil);
 }
 
@@ -73,7 +72,6 @@
     return;
   }
 
-  [views_[viewId] dispose];
   views_.erase(viewId);
   result(nil);
 }

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h

@@ -22,7 +22,7 @@ class FlutterPlatformViewsController {
  private:
   fml::scoped_nsobject<FlutterMethodChannel> channel_;
   std::map<std::string, fml::scoped_nsobject<NSObject<FlutterPlatformViewFactory>>> factories_;
-  std::map<long long, fml::scoped_nsobject<NSObject<FlutterPlatformView>>> views_;
+  std::map<int64_t, fml::scoped_nsobject<UIView>> views_;
 
   void OnMethodCall(FlutterMethodCall* call, FlutterResult& result);
   void OnCreate(FlutterMethodCall* call, FlutterResult& result);