Vulkan: Re-enable release ASSERTs.

null77 · Commit Bot · commit ed6e230ec65e · 2019-10-17T01:22:35.000Z
This change will broadcast the release asserts config to all ANGLE targets. Instead of the ones that inherited from angle_common. Bug: angleproject:4021 Change-Id: I574b01d47e85004f69fb59856cac7b10f0d8d170 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1864726 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
diff --git a/BUILD.gn b/BUILD.gn
@@ -287,7 +287,6 @@ angle_static_library("angle_common") {
     ":includes",
   ]
   public_configs += [ ":angle_common_config" ]
-  all_dependent_configs = [ ":angle_release_asserts_config" ]
   if (angle_has_build && use_fuzzing_engine) {
     all_dependent_configs += [ ":angle_disable_pool_alloc" ]
   }
diff --git a/gni/angle.gni b/gni/angle.gni
@@ -113,6 +113,7 @@ declare_args() {
 }
 
 angle_common_configs = [
+  angle_root + ":angle_release_asserts_config",
   angle_root + ":better_linux_stack_traces",
   angle_root + ":extra_warnings",
   angle_root + ":internal_config",

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,6 @@ angle_static_library("angle_common") {`
`287`	`287`	`":includes",`
`288`	`288`	`]`
`289`	`289`	`public_configs += [ ":angle_common_config" ]`
`290`		`- all_dependent_configs = [ ":angle_release_asserts_config" ]`
`291`	`290`	`if (angle_has_build && use_fuzzing_engine) {`
`292`	`291`	`all_dependent_configs += [ ":angle_disable_pool_alloc" ]`
`293`	`292`	`}`
Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,7 @@ declare_args() {`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`angle_common_configs = [`
	`116`	`+ angle_root + ":angle_release_asserts_config",`
`116`	`117`	`angle_root + ":better_linux_stack_traces",`
`117`	`118`	`angle_root + ":extra_warnings",`
`118`	`119`	`angle_root + ":internal_config",`