started invalidating mipmaps

Author: gaaclarke

impeller/core/texture.cc

@@ -86,4 +86,8 @@ bool Texture::NeedsMipmapGeneration() const {
   return !mipmap_generated_ && desc_.mip_count > 1;
 }
 
+void Texture::InvalidateMipmap() {
+  mipmap_generated_ = false;
+}
+
 }  // namespace impeller

impeller/core/texture.h

@@ -47,6 +47,8 @@ class Texture {
 
   bool NeedsMipmapGeneration() const;
 
+  void InvalidateMipmap();
+
  protected:
   explicit Texture(TextureDescriptor desc);
 

impeller/entity/contents/filters/filter_contents.cc

@@ -50,6 +50,8 @@ std::shared_ptr<FilterContents> FilterContents::MakeDirectionalGaussianBlur(
   return blur;
 }
 
+#define IMPELLER_ENABLE_NEW_GAUSSIAN_FILTER 1
+
 std::shared_ptr<FilterContents> FilterContents::MakeGaussianBlur(
     const FilterInput::Ref& input,
     Sigma sigma_x,

impeller/entity/contents/filters/gaussian_blur_filter_contents.cc

@@ -288,6 +288,7 @@ std::optional<Entity> GaussianBlurFilterContents::RenderFilter(
   }
 
   if (input_snapshot.value().texture->NeedsMipmapGeneration()) {
+    FML_LOG(ERROR) << "should generate mipmap";
     std::shared_ptr<CommandBuffer> mip_cmd_buffer =
         renderer.GetContext()->CreateCommandBuffer();
     std::shared_ptr<BlitPass> blit_pass = mip_cmd_buffer->CreateBlitPass();

impeller/entity/entity_pass.cc

@@ -346,6 +346,13 @@ bool EntityPass::Render(ContentContext& renderer,
         renderer, root_render_target.GetRenderTargetSize(), /*mip_count=*/4,
         GetClearColorOrDefault(render_target.GetRenderTargetSize()));
 
+    offscreen_target.GetRenderTarget()
+        .GetRenderTargetTexture()
+        ->InvalidateMipmap();
+    FML_LOG(ERROR)
+        << "invalidating mips: "
+        << offscreen_target.GetRenderTarget().GetRenderTargetTexture();
+
     if (!OnRender(renderer,  // renderer
                   capture,   // capture
                   offscreen_target.GetRenderTarget()

impeller/renderer/backend/metal/texture_mtl.mm

@@ -139,6 +139,8 @@ new TextureMTL(
     return false;
   }
 
+  FML_LOG(ERROR) << "mipmap generated";
+
   [encoder generateMipmapsForTexture:texture];
   mipmap_generated_ = true;
 

impeller/renderer/render_target.cc

@@ -314,6 +314,10 @@ RenderTarget RenderTarget::CreateOffscreenMSAA(
   color0_resolve_tex_desc.mip_count = mip_count;
 
   auto color0_resolve_tex = allocator.CreateTexture(color0_resolve_tex_desc);
+  if (mip_count > 1) {
+    FML_LOG(ERROR) << "created mip resolve texture: " << color0_resolve_tex
+                   << " " << mip_count;
+  }
   if (!color0_resolve_tex) {
     VALIDATION_LOG << "Could not create color texture.";
     return {};