Feedback

Author: loic-sharma

runtime/runtime_controller.cc

@@ -184,7 +184,6 @@ bool RuntimeController::RemoveView(int64_t view_id) {
         pending_add_view_callbacks_.end()) {
       pending_add_view_callbacks_[view_id](false);
       pending_add_view_callbacks_.erase(view_id);
-      return true;
     }
 
     return false;

shell/common/shell_unittests.cc

@@ -4698,7 +4698,7 @@ TEST_F(ShellTest, ShellFlushesPlatformStatesByMain) {
     // This effectively cancels the pending add view operation.
     shell->AddView(2, ViewportMetrics{1, 30, 1, 0, 0},
                    [](bool added) { ASSERT_FALSE(added); });
-    shell->RemoveView(2, [](bool removed) { ASSERT_TRUE(removed); });
+    shell->RemoveView(2, [](bool removed) { ASSERT_FALSE(removed); });
   });
 
   bool first_report = true;