made the fuzzy paramters specific to the whole runner, not the test suite

Author: gaaclarke

impeller/golden_tests/golden_digest.cc

@@ -6,6 +6,9 @@
 
 #include <fstream>
 
+static const double kMaxDiffPixelsPercent = 0.01;
+static const int32_t kMaxColorDelta = 8;
+
 namespace impeller {
 namespace testing {
 
@@ -23,11 +26,9 @@ GoldenDigest::GoldenDigest() {}
 void GoldenDigest::AddImage(const std::string& test_name,
                             const std::string& filename,
                             int32_t width,
-                            int32_t height,
-                            double max_diff_pixels_percent,
-                            int32_t max_color_delta) {
-  entries_.push_back({test_name, filename, width, height,
-                      max_diff_pixels_percent, max_color_delta});
+                            int32_t height) {
+  entries_.push_back({test_name, filename, width, height, kMaxDiffPixelsPercent,
+                      kMaxColorDelta});
 }
 
 bool GoldenDigest::Write(WorkingDirectory* working_directory) {

impeller/golden_tests/golden_digest.h

@@ -21,9 +21,7 @@ class GoldenDigest {
   void AddImage(const std::string& test_name,
                 const std::string& filename,
                 int32_t width,
-                int32_t height,
-                double max_diff_pixels_percent,
-                int32_t max_color_delta);
+                int32_t height);
 
   /// Writes a "digest.json" file to `working_directory`.
   ///

impeller/golden_tests/golden_playground_test_mac.cc

@@ -28,17 +28,14 @@ std::string GetGoldenFilename() {
   return GetTestName() + ".png";
 }
 
-bool SaveScreenshot(std::unique_ptr<testing::MetalScreenshot> screenshot,
-                    double max_diff_pixels_percent,
-                    int32_t max_color_delta) {
+bool SaveScreenshot(std::unique_ptr<testing::MetalScreenshot> screenshot) {
   if (!screenshot || !screenshot->GetBytes()) {
     return false;
   }
   std::string test_name = GetTestName();
   std::string filename = GetGoldenFilename();
   testing::GoldenDigest::Instance()->AddImage(
-      test_name, filename, screenshot->GetWidth(), screenshot->GetHeight(),
-      max_diff_pixels_percent, max_color_delta);
+      test_name, filename, screenshot->GetWidth(), screenshot->GetHeight());
   return screenshot->WriteToPNG(
       testing::WorkingDirectory::Instance()->GetFilenamePath(filename));
 }
@@ -48,8 +45,6 @@ struct GoldenPlaygroundTest::GoldenPlaygroundTestImpl {
   GoldenPlaygroundTestImpl() : screenshoter(new testing::MetalScreenshoter()) {}
   std::unique_ptr<testing::MetalScreenshoter> screenshoter;
   ISize window_size = ISize{1024, 768};
-  const double max_diff_pixels_percent = 0.01;
-  const int32_t max_color_delta = 8;
 };
 
 GoldenPlaygroundTest::GoldenPlaygroundTest()
@@ -103,8 +98,7 @@ PlaygroundBackend GoldenPlaygroundTest::GetBackend() const {
 bool GoldenPlaygroundTest::OpenPlaygroundHere(const Picture& picture) {
   auto screenshot =
       pimpl_->screenshoter->MakeScreenshot(picture, pimpl_->window_size);
-  return SaveScreenshot(std::move(screenshot), pimpl_->max_diff_pixels_percent,
-                        pimpl_->max_color_delta);
+  return SaveScreenshot(std::move(screenshot));
 }
 
 bool GoldenPlaygroundTest::OpenPlaygroundHere(

impeller/golden_tests/golden_tests.cc

@@ -31,6 +31,19 @@ std::string GetTestName() {
 std::string GetGoldenFilename() {
   return GetTestName() + ".png";
 }
+
+bool SaveScreenshot(std::unique_ptr<MetalScreenshot> screenshot) {
+  if (!screenshot || !screenshot->GetBytes()) {
+    return false;
+  }
+  std::string test_name = GetTestName();
+  std::string filename = GetGoldenFilename();
+  GoldenDigest::Instance()->AddImage(
+      test_name, filename, screenshot->GetWidth(), screenshot->GetHeight());
+  return screenshot->WriteToPNG(
+      WorkingDirectory::Instance()->GetFilenamePath(filename));
+}
+
 }  // namespace
 
 class GoldenTests : public ::testing::Test {
@@ -39,23 +52,8 @@ class GoldenTests : public ::testing::Test {
 
   MetalScreenshoter& Screenshoter() { return *screenshoter_; }
 
-  bool SaveScreenshot(std::unique_ptr<MetalScreenshot> screenshot) {
-    if (!screenshot || !screenshot->GetBytes()) {
-      return false;
-    }
-    std::string test_name = GetTestName();
-    std::string filename = GetGoldenFilename();
-    GoldenDigest::Instance()->AddImage(
-        test_name, filename, screenshot->GetWidth(), screenshot->GetHeight(),
-        max_diff_pixels_percent_, max_color_delta_);
-    return screenshot->WriteToPNG(
-        WorkingDirectory::Instance()->GetFilenamePath(filename));
-  }
-
  private:
   std::unique_ptr<MetalScreenshoter> screenshoter_;
-  const double max_diff_pixels_percent_ = 0.01;
-  const int32_t max_color_delta_ = 8;
 };
 
 TEST_F(GoldenTests, ConicalGradient) {