[Impeller] disable entity culling by default.

Author: jonahwilliams

impeller/entity/contents/clip_contents.cc

@@ -62,9 +62,8 @@ Contents::ClipCoverage ClipContents::GetClipCoverage(
   FML_UNREACHABLE();
 }
 
-bool ClipContents::ShouldRender(
-    const Entity& entity,
-    const std::optional<Rect>& clip_coverage) const {
+bool ClipContents::ShouldRender(const Entity& entity,
+                                const Rect& clip_coverage) const {
   return true;
 }
 
@@ -159,9 +158,8 @@ Contents::ClipCoverage ClipRestoreContents::GetClipCoverage(
   return {.type = ClipCoverage::Type::kRestore, .coverage = std::nullopt};
 }
 
-bool ClipRestoreContents::ShouldRender(
-    const Entity& entity,
-    const std::optional<Rect>& clip_coverage) const {
+bool ClipRestoreContents::ShouldRender(const Entity& entity,
+                                       const Rect& clip_coverage) const {
   return true;
 }
 

impeller/entity/contents/clip_contents.h

@@ -35,7 +35,7 @@ class ClipContents final : public Contents {
 
   // |Contents|
   bool ShouldRender(const Entity& entity,
-                    const std::optional<Rect>& clip_coverage) const override;
+                    const Rect& clip_coverage) const override;
 
   // |Contents|
   bool Render(const ContentContext& renderer,
@@ -78,7 +78,7 @@ class ClipRestoreContents final : public Contents {
 
   // |Contents|
   bool ShouldRender(const Entity& entity,
-                    const std::optional<Rect>& clip_coverage) const override;
+                    const Rect& clip_coverage) const override;
 
   // |Contents|
   bool Render(const ContentContext& renderer,

impeller/entity/contents/contents.cc

@@ -131,19 +131,15 @@ bool Contents::ApplyColorFilter(
 }
 
 bool Contents::ShouldRender(const Entity& entity,
-                            const std::optional<Rect>& clip_coverage) const {
-  if (!clip_coverage.has_value()) {
-    return false;
-  }
-
+                            const Rect& clip_coverage) const {
   auto coverage = GetCoverage(entity);
   if (!coverage.has_value()) {
     return false;
   }
   if (coverage == Rect::MakeMaximum()) {
     return true;
   }
-  return clip_coverage->IntersectsWithRect(coverage.value());
+  return clip_coverage.IntersectsWithRect(coverage.value());
 }
 
 void Contents::SetCoverageHint(std::optional<Rect> coverage_hint) {

impeller/entity/contents/contents.h

@@ -123,7 +123,7 @@ class Contents {
       const std::string& label = "Snapshot") const;
 
   virtual bool ShouldRender(const Entity& entity,
-                            const std::optional<Rect>& clip_coverage) const;
+                            const Rect& clip_coverage) const;
 
   //----------------------------------------------------------------------------
   /// @brief  Return the color source's intrinsic size, if available.

impeller/entity/entity.cc

@@ -71,7 +71,14 @@ Contents::ClipCoverage Entity::GetClipCoverage(
 }
 
 bool Entity::ShouldRender(const std::optional<Rect>& clip_coverage) const {
-  return contents_->ShouldRender(*this, clip_coverage);
+  if (!clip_coverage.has_value()) {
+    return false;
+  }
+#ifdef IMPELLER_CONTENT_CULLING
+  return contents_->ShouldRender(*this, clip_coverage.value());
+#else
+  return true;
+#endif  // IMPELLER_CONTENT_CULLING
 }
 
 void Entity::SetContents(std::shared_ptr<Contents> contents) {