Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 98cf15c

Browse files
danrubelcommit-bot@chromium.org
authored andcommitted
Remove unnecessary commentToken parameter
Minor cleanup to the dartdoc parsing API Change-Id: I7aa4c0116277beeef39553f1c133aa1ab8904d61 Reviewed-on: https://dart-review.googlesource.com/68700 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Dan Rubel <danrubel@google.com>
1 parent 89fd468 commit 98cf15c

4 files changed

Lines changed: 7 additions & 14 deletions

File tree

pkg/analyzer/lib/src/fasta/ast_builder.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2560,8 +2560,7 @@ class AstBuilder extends StackListener {
25602560
}
25612561

25622562
@override
2563-
void handleCommentReferenceText(
2564-
Token commentToken, String referenceSource, int referenceOffset) {
2563+
void handleCommentReferenceText(String referenceSource, int referenceOffset) {
25652564
ScannerResult result = scanString(referenceSource);
25662565
if (result.hasErrors) {
25672566
handleNoCommentReference();
@@ -2571,7 +2570,7 @@ class AstBuilder extends StackListener {
25712570
token.offset += referenceOffset;
25722571
token = token.next;
25732572
} while (!token.isEof);
2574-
parser.parseOneCommentReference(commentToken, result.tokens);
2573+
parser.parseOneCommentReference(result.tokens);
25752574
}
25762575
}
25772576

pkg/front_end/lib/src/fasta/parser/forwarding_listener.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -929,10 +929,8 @@ class ForwardingListener implements Listener {
929929
}
930930

931931
@override
932-
void handleCommentReferenceText(
933-
Token commentToken, String referenceSource, int referenceOffset) {
934-
listener?.handleCommentReferenceText(
935-
commentToken, referenceSource, referenceOffset);
932+
void handleCommentReferenceText(String referenceSource, int referenceOffset) {
933+
listener?.handleCommentReferenceText(referenceSource, referenceOffset);
936934
}
937935

938936
@override

pkg/front_end/lib/src/fasta/parser/listener.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1238,16 +1238,15 @@ class Listener implements UnescapeErrorListener {
12381238
/// parsed should be discarded, and a new type should be parsed instead.
12391239
void discardTypeReplacedWithCommentTypeAssign() {}
12401240

1241-
/// A single comment reference in [commentToken] has been found where
1241+
/// A single comment reference has been found
12421242
/// where [referenceSource] is the text between the `[` and `]`
12431243
/// and [referenceOffset] is the character offset in the token stream.
12441244
///
12451245
/// This event is generated by the parser when the parser's
12461246
/// `parseCommentReferences` method is called. For further processing,
12471247
/// a listener may scan the [referenceSource] and then pass the resulting
12481248
/// token stream to the parser's `parseOneCommentReference` method.
1249-
void handleCommentReferenceText(
1250-
Token commentToken, String referenceSource, int referenceOffset) {
1249+
void handleCommentReferenceText(String referenceSource, int referenceOffset) {
12511250
logEvent("CommentReferenceText");
12521251
}
12531252

pkg/front_end/lib/src/fasta/parser/parser.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import '../../scanner/token.dart'
1515
ASSIGNMENT_PRECEDENCE,
1616
BeginToken,
1717
CASCADE_PRECEDENCE,
18-
DocumentationCommentToken,
1918
EQUALITY_PRECEDENCE,
2019
Keyword,
2120
POSTFIX_PRECEDENCE,
@@ -5954,7 +5953,6 @@ class Parser {
59545953
// URI in the link text.
59555954
} else {
59565955
listener.handleCommentReferenceText(
5957-
commentToken,
59585956
comment.substring(referenceStart, index),
59595957
commentToken.charOffset + referenceStart);
59605958
++count;
@@ -6006,8 +6004,7 @@ class Parser {
60066004
///
60076005
/// This is typically called from the listener's
60086006
/// `handleCommentReferenceText` method.
6009-
void parseOneCommentReference(
6010-
DocumentationCommentToken commentToken, Token token) {
6007+
void parseOneCommentReference(Token token) {
60116008
Token begin = token;
60126009
Token newKeyword = null;
60136010
if (optional('new', token)) {

0 commit comments

Comments
 (0)