Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 92ae73b

Browse files
bwilkersoncommit-bot@chromium.org
authored andcommitted
Fork the remaining subclasses of AbstractAnalysisClass
Change-Id: Ie3e561a6b6f4d29510f543d616998c795fd85191 Reviewed-on: https://dart-review.googlesource.com/68120 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
1 parent 884536d commit 92ae73b

13 files changed

Lines changed: 370 additions & 66 deletions

pkg/analysis_server/test/completion_test.dart

Lines changed: 248 additions & 66 deletions
Large diffs are not rendered by default.

pkg/analysis_server/test/completion_test_support.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,11 @@ class CompletionTestCase extends CompletionDomainHandlerTest {
103103
}
104104
}
105105

106+
class CompletionTestCase_UseCFE extends CompletionTestCase {
107+
@override
108+
bool get useCFE => true;
109+
}
110+
106111
/**
107112
* A specification of the completion results expected at a given location.
108113
*/

pkg/analysis_server/test/domain_analysis_test.dart

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@ import 'mocks.dart';
2626
main() {
2727
defineReflectiveSuite(() {
2828
defineReflectiveTests(AnalysisDomainTest);
29+
defineReflectiveTests(AnalysisDomainTest_UseCFE);
2930
defineReflectiveTests(AnalysisDomainHandlerTest);
31+
defineReflectiveTests(AnalysisDomainHandlerTest_UseCFE);
3032
defineReflectiveTests(SetSubscriptionsTest);
33+
defineReflectiveTests(SetSubscriptionsTest_UseCFE);
3134
});
3235
}
3336

@@ -301,6 +304,12 @@ class AnalysisDomainHandlerTest extends AbstractAnalysisTest {
301304
}
302305
}
303306

307+
@reflectiveTest
308+
class AnalysisDomainHandlerTest_UseCFE extends AnalysisDomainHandlerTest {
309+
@override
310+
bool get useCFE => true;
311+
}
312+
304313
@reflectiveTest
305314
class AnalysisDomainTest extends AbstractAnalysisTest {
306315
Map<String, List<AnalysisError>> filesErrors = {};
@@ -335,6 +344,12 @@ main(A a) {
335344
}
336345
}
337346

347+
@reflectiveTest
348+
class AnalysisDomainTest_UseCFE extends AnalysisDomainTest {
349+
@override
350+
bool get useCFE => true;
351+
}
352+
338353
/**
339354
* A helper to test 'analysis.*' requests.
340355
*/
@@ -701,3 +716,14 @@ class A {}
701716
expect(files, [testFile]);
702717
}
703718
}
719+
720+
@reflectiveTest
721+
class SetSubscriptionsTest_UseCFE extends SetSubscriptionsTest {
722+
@override
723+
bool get useCFE => true;
724+
725+
@failingTest
726+
@override
727+
test_afterAnalysis_noSuchFile() async =>
728+
callFailingTest(super.test_afterAnalysis_noSuchFile());
729+
}

pkg/analysis_server/test/edit/assists_test.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import '../analysis_abstract.dart';
2020
main() {
2121
defineReflectiveSuite(() {
2222
defineReflectiveTests(AssistsTest);
23+
defineReflectiveTests(AssistsTest_UseCFE);
2324
});
2425
}
2526

@@ -132,3 +133,9 @@ main() {
132133
fail("Expected to find |$message| in\n" + changes.join('\n'));
133134
}
134135
}
136+
137+
@reflectiveTest
138+
class AssistsTest_UseCFE extends AssistsTest {
139+
@override
140+
bool get useCFE => true;
141+
}

pkg/analysis_server/test/edit/fixes_test.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import '../analysis_abstract.dart';
2020
main() {
2121
defineReflectiveSuite(() {
2222
defineReflectiveTests(FixesTest);
23+
defineReflectiveTests(FixesTest_UseCFE);
2324
});
2425
}
2526

@@ -169,3 +170,13 @@ bbb:${asFileUri('/bbb/lib')}
169170
expect(fixes.fixes, hasLength(1));
170171
}
171172
}
173+
174+
@reflectiveTest
175+
class FixesTest_UseCFE extends FixesTest {
176+
@override
177+
bool get useCFE => true;
178+
179+
@failingTest
180+
@override
181+
test_fixUndefinedClass() => super.test_fixUndefinedClass();
182+
}

pkg/analysis_server/test/edit/format_test.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import '../mocks.dart';
1717
main() {
1818
defineReflectiveSuite(() {
1919
defineReflectiveTests(FormatTest);
20+
defineReflectiveTests(FormatTest_UseCFE);
2021
});
2122
}
2223

@@ -123,3 +124,9 @@ main() { int x =
123124
return new EditFormatResult.fromResponse(response);
124125
}
125126
}
127+
128+
@reflectiveTest
129+
class FormatTest_UseCFE extends FormatTest {
130+
@override
131+
bool get useCFE => true;
132+
}

pkg/analysis_server/test/edit/organize_directives_test.dart

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import '../mocks.dart';
1717
main() {
1818
defineReflectiveSuite(() {
1919
defineReflectiveTests(OrganizeDirectivesTest);
20+
defineReflectiveTests(OrganizeDirectivesTest_UseCFE);
2021
});
2122
}
2223

@@ -166,3 +167,21 @@ main() {
166167
fileEdit = result.edit;
167168
}
168169
}
170+
171+
@reflectiveTest
172+
class OrganizeDirectivesTest_UseCFE extends OrganizeDirectivesTest {
173+
@override
174+
bool get useCFE => true;
175+
176+
@override
177+
test_BAD_doesNotExist() async => super.test_BAD_doesNotExist();
178+
179+
@failingTest
180+
@override
181+
test_OK_remove_unresolvedDirectives() async =>
182+
super.test_OK_remove_unresolvedDirectives();
183+
184+
@failingTest
185+
@override
186+
test_OK_remove_unusedImports() async => super.test_OK_remove_unusedImports();
187+
}

pkg/analysis_server/test/edit/postfix_completion_test.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import '../analysis_abstract.dart';
1414
main() {
1515
defineReflectiveSuite(() {
1616
defineReflectiveTests(PostfixCompletionTest);
17+
defineReflectiveTests(PostfixCompletionTest_UseCFE);
1718
});
1819
}
1920

@@ -91,3 +92,9 @@ main() {
9192
change = result.change;
9293
}
9394
}
95+
96+
@reflectiveTest
97+
class PostfixCompletionTest_UseCFE extends PostfixCompletionTest {
98+
@override
99+
bool get useCFE => true;
100+
}

pkg/analysis_server/test/edit/sort_members_test.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import '../mocks.dart';
1717
main() {
1818
defineReflectiveSuite(() {
1919
defineReflectiveTests(SortMembersTest);
20+
defineReflectiveTests(SortMembersTest_UseCFE);
2021
});
2122
}
2223

@@ -254,3 +255,9 @@ class C {}
254255
fileEdit = result.edit;
255256
}
256257
}
258+
259+
@reflectiveTest
260+
class SortMembersTest_UseCFE extends SortMembersTest {
261+
@override
262+
bool get useCFE => true;
263+
}

pkg/analysis_server/test/edit/statement_completion_test.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import '../analysis_abstract.dart';
1414
main() {
1515
defineReflectiveSuite(() {
1616
defineReflectiveTests(StatementCompletionTest);
17+
defineReflectiveTests(StatementCompletionTest_UseCFE);
1718
});
1819
}
1920

@@ -120,3 +121,9 @@ main() {
120121
change = result.change;
121122
}
122123
}
124+
125+
@reflectiveTest
126+
class StatementCompletionTest_UseCFE extends StatementCompletionTest {
127+
@override
128+
bool get useCFE => true;
129+
}

0 commit comments

Comments
 (0)