Address feedback

Author: loic-sharma

shell/platform/windows/flutter_window.cc

@@ -373,7 +373,7 @@ ui::AXPlatformNodeWin* FlutterWindow::GetAlert() {
   return alert_node_.get();
 }
 
-bool FlutterWindow::NeedsVSync() {
+bool FlutterWindow::NeedsVSync() const {
   // If the Desktop Window Manager composition is enabled,
   // the system itself synchronizes with v-sync.
   // See: https://learn.microsoft.com/windows/win32/dwm/composition-ovw

shell/platform/windows/flutter_window.h

@@ -196,7 +196,7 @@ class FlutterWindow : public KeyboardManager::WindowDelegate,
   virtual ui::AXPlatformNodeWin* GetAlert() override;
 
   // |WindowBindingHandler|
-  virtual bool NeedsVSync() override;
+  virtual bool NeedsVSync() const override;
 
   // Called to obtain a pointer to the fragment root delegate.
   virtual ui::AXFragmentRootDelegateWin* GetAxFragmentRootDelegate();

shell/platform/windows/flutter_windows_engine.cc

@@ -685,7 +685,7 @@ bool FlutterWindowsEngine::MarkExternalTextureFrameAvailable(
               engine_, texture_id) == kSuccess);
 }
 
-bool FlutterWindowsEngine::PostRasterThreadTask(fml::closure callback) {
+bool FlutterWindowsEngine::PostRasterThreadTask(fml::closure callback) const {
   struct Captures {
     fml::closure callback;
   };

shell/platform/windows/flutter_windows_engine.h

@@ -102,7 +102,7 @@ class FlutterWindowsEngine {
   bool Run(std::string_view entrypoint);
 
   // Returns true if the engine is currently running.
-  virtual bool running() { return engine_ != nullptr; }
+  virtual bool running() const { return engine_ != nullptr; }
 
   // Stops the engine. This invalidates the pointer returned by engine().
   //
@@ -141,7 +141,9 @@ class FlutterWindowsEngine {
 
   // The ANGLE surface manager object. If this is nullptr, then we are
   // rendering using software instead of OpenGL.
-  AngleSurfaceManager* surface_manager() { return surface_manager_.get(); }
+  AngleSurfaceManager* surface_manager() const {
+    return surface_manager_.get();
+  }
 
   WindowProcDelegateManager* window_proc_delegate_manager() {
     return window_proc_delegate_manager_.get();
@@ -201,7 +203,7 @@ class FlutterWindowsEngine {
   bool MarkExternalTextureFrameAvailable(int64_t texture_id);
 
   // Posts the given callback onto the raster thread.
-  virtual bool PostRasterThreadTask(fml::closure callback);
+  virtual bool PostRasterThreadTask(fml::closure callback) const;
 
   // Invoke on the embedder's vsync callback to schedule a frame.
   void OnVsync(intptr_t baton);

shell/platform/windows/flutter_windows_view.cc

@@ -25,10 +25,10 @@ constexpr std::chrono::milliseconds kWindowResizeTimeout{100};
 /// to be blocked until the frame with the right size has been rendered. It
 /// should be kept in-sync with how the engine deals with a new surface request
 /// as seen in `CreateOrUpdateSurface` in `GPUSurfaceGL`.
-static bool SurfaceWillUpdate(size_t cur_width,
-                              size_t cur_height,
-                              size_t target_width,
-                              size_t target_height) {
+bool SurfaceWillUpdate(size_t cur_width,
+                       size_t cur_height,
+                       size_t target_width,
+                       size_t target_height) {
   // TODO (https://github.com/flutter/flutter/issues/65061) : Avoid special
   // handling for zero dimensions.
   bool non_zero_target_dims = target_height > 0 && target_width > 0;
@@ -39,8 +39,8 @@ static bool SurfaceWillUpdate(size_t cur_width,
 
 /// Update the surface's swap interval to block until the v-blank iff
 /// the system compositor is disabled.
-static void UpdateVsync(FlutterWindowsEngine& engine,
-                        WindowBindingHandler& window) {
+void UpdateVsync(const FlutterWindowsEngine& engine,
+                 const WindowBindingHandler& window) {
   AngleSurfaceManager* surface_manager = engine.surface_manager();
   if (!surface_manager) {
     return;

shell/platform/windows/flutter_windows_view_unittests.cc

@@ -110,9 +110,9 @@ class MockFlutterWindowsEngine : public FlutterWindowsEngine {
  public:
   MockFlutterWindowsEngine() : FlutterWindowsEngine(GetTestProject()) {}
 
-  MOCK_METHOD(bool, running, (), ());
+  MOCK_METHOD(bool, running, (), (const));
   MOCK_METHOD(bool, Stop, (), ());
-  MOCK_METHOD(bool, PostRasterThreadTask, (fml::closure), ());
+  MOCK_METHOD(bool, PostRasterThreadTask, (fml::closure), (const));
 
  private:
   FML_DISALLOW_COPY_AND_ASSIGN(MockFlutterWindowsEngine);

shell/platform/windows/testing/mock_window_binding_handler.h

@@ -40,7 +40,7 @@ class MockWindowBindingHandler : public WindowBindingHandler {
   MOCK_METHOD(PointerLocation, GetPrimaryPointerLocation, (), (override));
   MOCK_METHOD(AlertPlatformNodeDelegate*, GetAlertDelegate, (), (override));
   MOCK_METHOD(ui::AXPlatformNodeWin*, GetAlert, (), (override));
-  MOCK_METHOD(bool, NeedsVSync, (), (override));
+  MOCK_METHOD(bool, NeedsVSync, (), (const override));
 
  private:
   FML_DISALLOW_COPY_AND_ASSIGN(MockWindowBindingHandler);

shell/platform/windows/window_binding_handler.h

@@ -106,7 +106,7 @@ class WindowBindingHandler {
 
   // If true, rendering to the window should synchronize with the vsync
   // to prevent screen tearing.
-  virtual bool NeedsVSync() = 0;
+  virtual bool NeedsVSync() const = 0;
 };
 
 }  // namespace flutter