Review updates

Author: George Wright

shell/platform/darwin/macos/framework/Source/FlutterDartProject.mm

@@ -16,7 +16,6 @@ @implementation FlutterDartProject {
   NSBundle* _dartBundle;
   NSString* _assetsPath;
   NSString* _ICUDataPath;
-  NSArray* _entrypointArguments;
 }
 
 - (instancetype)init {
@@ -28,10 +27,10 @@ - (instancetype)initWithPrecompiledDartBundle:(NSBundle*)bundle {
   NSAssert(self, @"Super init cannot be nil");
 
   _dartBundle = bundle ?: [NSBundle bundleWithIdentifier:kAppBundleIdentifier];
-  _entrypointArguments = [[NSProcessInfo processInfo] arguments];
+  _dartEntrypointArguments = [[NSProcessInfo processInfo] arguments];
   // Remove the first element as it's the binary name
-  _entrypointArguments =
-      [_entrypointArguments subarrayWithRange:NSMakeRange(1, _entrypointArguments.count - 1)];
+  _dartEntrypointArguments = [_dartEntrypointArguments
+      subarrayWithRange:NSMakeRange(1, _dartEntrypointArguments.count - 1)];
   return self;
 }
 
@@ -82,12 +81,4 @@ - (NSString*)ICUDataPath {
   return arguments;
 }
 
-- (void)setDartEntrypointArguments:(NSArray*)arguments {
-  _entrypointArguments = arguments;
-}
-
-- (NSArray*)dartEntrypointArguments {
-  return _entrypointArguments;
-}
-
 @end

shell/platform/darwin/macos/framework/Source/FlutterEngine.mm

@@ -264,12 +264,9 @@ - (BOOL)runWithEntrypoint:(NSString*)entrypoint {
   std::transform(switches.begin(), switches.end(), std::back_inserter(argv),
                  [](const std::string& arg) -> const char* { return arg.c_str(); });
 
-  NSArray* entrypointArguments = [_project dartEntrypointArguments];
-  NSEnumerator* enumerator = [entrypointArguments objectEnumerator];
-  NSString* argument;
-  std::vector<const char*> dart_entrypoint_args;
-  while (argument = [enumerator nextObject]) {
-    dart_entrypoint_args.push_back([argument UTF8String]);
+  std::vector<const char*> dartEntrypointArgs;
+  for (NSString* argument in [_project dartEntrypointArguments]) {
+    dartEntrypointArgs.push_back([argument UTF8String]);
   }
 
   FlutterProjectArgs flutterArguments = {};
@@ -281,8 +278,8 @@ - (BOOL)runWithEntrypoint:(NSString*)entrypoint {
   flutterArguments.platform_message_callback = (FlutterPlatformMessageCallback)OnPlatformMessage;
   flutterArguments.custom_dart_entrypoint = entrypoint.UTF8String;
   flutterArguments.shutdown_dart_vm_when_done = true;
-  flutterArguments.dart_entrypoint_argc = dart_entrypoint_args.size();
-  flutterArguments.dart_entrypoint_argv = dart_entrypoint_args.data();
+  flutterArguments.dart_entrypoint_argc = dartEntrypointArgs.size();
+  flutterArguments.dart_entrypoint_argv = dartEntrypointArgs.data();
 
   static size_t sTaskRunnerIdentifiers = 0;
   const FlutterTaskRunnerDescription cocoa_task_runner_description = {