diff --git a/app_dart/lib/src/request_handlers/github/webhook_subscription.dart b/app_dart/lib/src/request_handlers/github/webhook_subscription.dart index ed8c7ae4e5..fcfa650238 100644 --- a/app_dart/lib/src/request_handlers/github/webhook_subscription.dart +++ b/app_dart/lib/src/request_handlers/github/webhook_subscription.dart @@ -32,7 +32,7 @@ const Set kNeedsCheckLabelsAndTests = { 'flutter/plugins', }; -final RegExp kEngineTestRegExp = RegExp(r'(tests?|benchmarks?)\.(dart|java|mm|m|cc)$'); +final RegExp kEngineTestRegExp = RegExp(r'(tests?|benchmarks?)\.(dart|java|mm|m|cc|sh)$'); final List kNeedsTestsLabels = ['needs tests']; /// Subscription for processing GitHub webhooks. diff --git a/app_dart/test/request_handlers/github/webhook_subscription_test.dart b/app_dart/test/request_handlers/github/webhook_subscription_test.dart index 636bdb8625..7dba6b4732 100644 --- a/app_dart/test/request_handlers/github/webhook_subscription_test.dart +++ b/app_dart/test/request_handlers/github/webhook_subscription_test.dart @@ -1759,6 +1759,33 @@ void foo() { ); }); + test('Engine labels PRs, no comment if script tests', () async { + const int issueNumber = 123; + + tester.message = generateGithubWebhookMessage( + action: 'opened', + number: issueNumber, + slug: Config.engineSlug, + ); + + when(pullRequestsService.listFiles(Config.engineSlug, issueNumber)).thenAnswer( + (_) => Stream.fromIterable([ + PullRequestFile()..filename = 'fml/blah.cc', + PullRequestFile()..filename = 'fml/testing/blah_test.sh', + ]), + ); + + await tester.post(webhook); + + verifyNever( + issuesService.createComment( + Config.engineSlug, + issueNumber, + argThat(contains(config.missingTestsPullRequestMessageValue)), + ), + ); + }); + test('Engine labels PRs, no comment if cc tests', () async { const int issueNumber = 123; @@ -1794,7 +1821,7 @@ void foo() { ); }); - test('Engine labels PRs, no comment if cc becnhmarks', () async { + test('Engine labels PRs, no comment if cc benchmarks', () async { const int issueNumber = 123; tester.message = generateGithubWebhookMessage(