fix pending (#637)

Author: dnfield

app_dart/lib/src/request_handlers/check_for_waiting_pull_requests.dart

@@ -241,18 +241,19 @@ bool _checkStatuses(
   bool allSuccess = true;
   for (Map<String, dynamic> status in statuses) {
     final String name = status['context'];
-    if (status['state'] == 'FAILURE') {
+    if (status['state'] != 'SUCCESS') {
       allSuccess = false;
-      if (!notInAuthorsControl.contains(name)) {
+      if (status['state'] == 'FAILURE' && !notInAuthorsControl.contains(name)) {
         failures.add(name);
       }
     }
   }
   for (Map<String, dynamic> check in checks) {
     final String name = check['app']['name'];
-    if (check['conclusion'] == 'FAILURE') {
+    if (check['conclusion'] != 'SUCCESS') {
       allSuccess = false;
-      if (!notInAuthorsControl.contains(name)) {
+      if (check['conclusion'] == 'FAILURE' &&
+          !notInAuthorsControl.contains(name)) {
         failures.add(name);
       }
     }

app_dart/test/request_handlers/check_for_waiting_pull_requests_test.dart

@@ -149,6 +149,20 @@ void main() {
       );
     });
 
+    test('Does not merge PR with in progress tests', () async {
+      flutterRepoPRs.add(PullRequestHelper(
+        lastCommitStatuses: const <StatusHelper>[
+          StatusHelper('Linux Host', 'PENDING')
+        ],
+      ));
+
+      await tester.get(handler);
+
+      _verifyQueries();
+
+      githubGraphQLClient.verifyMutations(<MutationOptions>[]);
+    });
+
     test('Does not merge unapproved PR from a hacker', () async {
       config.rollerAccountsValue = <String>{'engine-roller', 'skia-roller'};
       flutterRepoPRs.add(PullRequestHelper(