Skip to content

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented May 8, 2025

follow-up #809

In this PR, I've found apt-arm executes duplicated binstubs test.

follow-up fluent#809

In this PR, I've found apt-arm executes duplicated binstubs test.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys requested review from Watson1978 and daipom May 8, 2025 07:32
@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

NOTE: test failed with on AlmaLinux 9.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
/usr/lib/rpmrebuild/rpmrebuild.sh: ERROR: (RpmUnpack) rpm2archive
/usr/lib/rpmrebuild/rpmrebuild.sh: ERROR: (CreateBuildRoot) RpmUnpack
/usr/lib/rpmrebuild/rpmrebuild.sh: ERROR: CreateBuildRoot

This is caused by rpm2archive | tar -xz ... failure.

@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

rpm -qf /usr/bin/rpm2archive 
rpm-4.16.1.3-34.el9.x86_64

rpm itself is not changed recently.

@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

rpm2archive generates an archive, so RpmUnpack function in /usr/lib/rpmrebuild/rpmrebuild.sh will not work.
It assume that rpm2archive generates tgz output, then pipe it to tar command.

if [ -n "$tst_rpm2archive" ]
        then
                Debug '(RpmUnpack) rpm2archive'
                rpm2archive ${RPMREBUILD_PAQUET} | tar -xz -C $BUILDROOT || Error "(RpmUnpack) rpm2archive" || return
        else

Thus, something like the following behavior is expected, but actually not.

HOME=/tmp cat ./fluent-package-5.2.0-1.el9.x86_64.rpm.tgz | tar -xz -C /tmp/root

@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

rpmrebuild 2.20-3 seems buggy, in rpmrebuild 2.16 era, it uses rpm2cpio.

@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

Already reported:

#18 rpmrebuild 2.20: rpm2archive called with incorrect arguments
https://sourceforge.net/p/rpmrebuild/bugs/18/

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenhys kenhys merged commit 4bc8c81 into fluent:fluent-package-v5 May 8, 2025
159 of 164 checks passed
@kenhys kenhys deleted the backport-813 branch May 8, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants