Skip to content

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented May 7, 2025

Backport #809

In the previous versions, some test cases are contained in Build job. It should be executed in a separate job by nature.

@kenhys kenhys marked this pull request as draft May 7, 2025 06:52
@Watson1978
Copy link
Contributor

Seems the following changing are missing in .github/workflows/yum.matrix.json
Is this expected?

image

@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

Seems the following changing are missing in .github/workflows/yum.matrix.json
Is this expected?

It should be changed, too. Thanks.

@kenhys kenhys marked this pull request as ready for review May 8, 2025 03:09
@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

As #820 was merged, rebased with branch.

@kenhys kenhys requested review from Watson1978 and daipom and removed request for Watson1978 and daipom May 8, 2025 04:13
@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

TODO: fix confluent test case.

It should be merged into separate PR because of conflicting issue.

( it requires to track changes #661 and the following PRs)

In the previous versions, some test cases are contained in Build job.
It should be executed in a separated job by nature.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys requested a review from daipom May 8, 2025 05:18
@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

known issue 💣: cool.io 1.8.1 is required on windows

socketry/cool.io#81


In file included from libev.c:8:25h25l
../libev/ev.c:213:10: warning: "FD_SETSIZE" redefined25h25l
  213 | # define FD_SETSIZE 102425h25l
      |          ^~~~~~~~~~25h25l
<command-line>: note: this is the location of the previous definition25h25l
../libev/ev.c:1839:31: warning: 'ev_default_loop_ptr' initialized and declared  25h25l
'extern'25h25l
1839 |   EV_API_DECL struct ev_loop *ev_default_loop_ptr = 0; /* needs to be    25h25l
initialised to make it a definition despite extern */25h25l
      |                               ^~~~~~~~~~~~~~~~~~~25h25l
../libev/ev.c: In function 'evpipe_write':25h25l
../libev/ev.c:2484:19: error: assignment to 'char *' from incompatible pointer  25h25l
type 'WSABUF *' [-Wincompatible-pointer-types]25h25l
 2484 |           buf.buf = &buf;25h25l
      |                   ^25h25l
make: *** [Makefile:248: libev.o] Error 125h25l

@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

Amazon Linux 2: known vagrant spin up issue.

@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

Almalinux9 test case should not be failed. this is blocker to merge it.

@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2025

Almalinux9 test case should not be failed. this is blocker to merge it.

+ rpmrebuild --release=2.el9 --package /host/almalinux/9/x86_64/Packages/fluent-package-5.0.6-1.el9.x86_64.rpm
  fluent-package-5.0.6-1.el9.x86_64
  (GenRpmQf) remove tag line ENHANCESFLAGS
  (GenRpmQf) remove tag line ENHANCESNAME
  (GenRpmQf) remove tag line ENHANCESVERSION
  (GenRpmQf) remove tag line SUGGESTSFLAGS
  (GenRpmQf) remove tag line SUGGESTSNAME
  (GenRpmQf) remove tag line SUGGESTSVERSION
  Error: Can't open output file: /host/almalinux/9/x86_64/Packages/fluent-package-5.0.6-1.el9.x86_64.rpm.tgz
  
  gzip: stdin: unexpected end of file

It seems this error was caused by rpmrebuild. it has nothing to do with this PR itself.

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenhys kenhys merged commit 9507772 into fluent:fluent-package-v5 May 8, 2025
143 of 158 checks passed
@kenhys kenhys deleted the backport-809 branch May 8, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants