Skip to content

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Feb 26, 2025

This PR will fix build error for CentOS 7 package.

Run DEBUG=yes rake yum:build YUM_TARGETS="centos-7" on your terminal.

NOTE:

  • This PR removes rdkafka gem from CentOS 7 package because librdkafka library can't be built.
  • This PR changes to ignore the build error of brp_python_bytecompile since it is unrelated to Fluentd and fails in some environments.

@Watson1978 Watson1978 force-pushed the centos7 branch 2 times, most recently from e8ff7ea to 3d16f7a Compare February 27, 2025 03:09
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days

@github-actions github-actions bot added the stale label May 28, 2025
Signed-off-by: Shizuo Fujita <[email protected]>
This will remove following files

* /root/rpmbuild/BUILDROOT/fluent-package-5.2.0-1.el7.x86_64/opt/fluent/lib/ruby/gems/3.2.0/gems/ffi-1.17.0/ext/ffi_c/libffi/generate-darwin-source-and-headers.py
* /root/rpmbuild/BUILDROOT/fluent-package-5.2.0-1.el7.x86_64/opt/fluent/lib/ruby/gems/3.2.0/gems/ffi-1.17.0/ext/ffi_c/libffi/testsuite/emscripten/test_libffi.py
* /root/rpmbuild/BUILDROOT/fluent-package-5.2.0-1.el7.x86_64/opt/fluent/lib/ruby/gems/3.2.0/gems/ffi-1.17.0/ext/ffi_c/libffi/testsuite/emscripten/conftest.py

Signed-off-by: Shizuo Fujita <[email protected]>
@Watson1978 Watson1978 removed the stale label Jun 27, 2025
This reverts commit 8e3391a.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
@Watson1978 Watson1978 marked this pull request as ready for review July 1, 2025 02:32
@Watson1978 Watson1978 requested review from daipom and kenhys July 1, 2025 02:35
@daipom
Copy link
Contributor

daipom commented Jul 3, 2025

Thanks! I see this today.

@Watson1978 Watson1978 requested a review from kenhys July 3, 2025 04:51
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom merged commit 6470f56 into fluent:master Jul 4, 2025
256 checks passed
@Watson1978 Watson1978 deleted the centos7 branch July 4, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants