out_http: add config option to allow disabling logging of HTTP 2xx successes

In a busy system with lots of different tags/chunks being handled, this can get really noisy in usual operation

Signed-off-by: Stewart Webb <[email protected]>

Author: nuclearpidgeon

plugins/out_http/http.c

@@ -338,16 +338,18 @@ static int http_request(struct flb_out_http *ctx,
             }
         }
         else {
-            if (ctx->log_response_payload &&
-                c->resp.payload && c->resp.payload_size > 0) {
-                flb_plg_info(ctx->ins, "%s:%i, HTTP status=%i\n%s",
-                             ctx->host, ctx->port,
-                             c->resp.status, c->resp.payload);
-            }
-            else {
-                flb_plg_info(ctx->ins, "%s:%i, HTTP status=%i",
-                             ctx->host, ctx->port,
-                             c->resp.status);
+            if (ctx->log_2xx_successes) {
+                if (ctx->log_response_payload &&
+                    c->resp.payload && c->resp.payload_size > 0) {
+                    flb_plg_info(ctx->ins, "%s:%i, HTTP status=%i\n%s",
+                                ctx->host, ctx->port,
+                                c->resp.status, c->resp.payload);
+                }
+                else {
+                    flb_plg_info(ctx->ins, "%s:%i, HTTP status=%i",
+                                ctx->host, ctx->port,
+                                c->resp.status);
+                }
             }
         }
     }
@@ -706,6 +708,11 @@ static struct flb_config_map config_map[] = {
      0, FLB_TRUE, offsetof(struct flb_out_http, log_response_payload),
      "Specify if the response paylod should be logged or not"
     },
+    {
+     FLB_CONFIG_MAP_BOOL, "log_2xx_successes", "true",
+     0, FLB_TRUE, offsetof(struct flb_out_http, log_2xx_successes),
+     "Specify if HTTP 2xx reponses should be logged or not"
+    },
     {
      FLB_CONFIG_MAP_TIME, "http.response_timeout", "60s",
      0, FLB_TRUE, offsetof(struct flb_out_http, response_timeout),

plugins/out_http/http.h

@@ -100,6 +100,9 @@ struct flb_out_http {
     /* Log the response paylod */
     int log_response_payload;
 
+    /* Whether 200 OK etc results should be logged or not */
+    int log_2xx_successes;
+
     /* Response timeout */
     int response_timeout;
 

plugins/out_http/http_conf.c

@@ -113,6 +113,10 @@ struct flb_out_http *flb_http_conf_create(struct flb_output_instance *ins,
         }
     }
 
+    if (ctx->log_response_payload && !ctx->log_2xx_oks) {
+        flb_plg_warn(ctx->ins, "log_response_payload is enabled but log_2xx_oks is disabled - response payloads from 2xx reponses won't be logged");
+    }
+
     /*
      * Check if a Proxy have been set, if so the Upstream manager will use
      * the Proxy end-point and then we let the HTTP client know about it, so