-
Notifications
You must be signed in to change notification settings - Fork 52
Replace go-bindata with embed #1122
Copy link
Copy link
Closed
Labels
backendIssues related to the backendIssues related to the backendenhancementNew feature or requestNew feature or requestgoPull requests that update Go codePull requests that update Go codegood first issueGood for newcomersGood for newcomers
Metadata
Metadata
Assignees
Labels
backendIssues related to the backendIssues related to the backendenhancementNew feature or requestNew feature or requestgoPull requests that update Go codePull requests that update Go codegood first issueGood for newcomersGood for newcomers
Type
Fields
Give feedbackNo fields configured for issues without a type.
Currently Nebraska is making use of
go-bindataI believe just to ship the sql migration files. I believe this was likely done pre Go 1.16 whereembeddidn't exist. Taking a look atgo-bindatatoday it doesn't seem like it's been maintained in some time and most projects I've seen have moved to make use ofembed(or at a minimum one of a few other projects that provide similar behavior).It would be good to take a look to see if the native functionality serves the purpose well or if another maintained library should be picked up for this.
Similar comments here: #14 (comment)