Commit 8e926de
Fix cute dsl gemm API wrong arg name and silent error when passing wrong kwargs (#1619)
<!-- .github/pull_request_template.md -->
## 📌 Description
* fix name error: not "mm" but "mn"
* make it explicitly fail now. o/w e.g. when users need to pass in
`signals` and wrongly use a old flashinfer version, they will not
realize it and get confusing errors.
<!-- What does this PR do? Briefly describe the changes and why they’re
needed. -->
## 🔍 Related Issues
<!-- Link any related issues here -->
## 🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull
request, please make sure the following items are complete.
### ✅ Pre-commit Checks
- [ ] I have installed `pre-commit` by running `pip install pre-commit`
(or used your preferred method).
- [ ] I have installed the hooks with `pre-commit install`.
- [ ] I have run the hooks manually with `pre-commit run --all-files`
and fixed any reported issues.
> If you are unsure about how to set up `pre-commit`, see [the
pre-commit documentation](https://pre-commit.com/).
## 🧪 Tests
- [ ] Tests have been added or updated as needed.
- [ ] All tests are passing (`unittest`, etc.).
## Reviewer Notes
<!-- Optional: anything you'd like reviewers to focus on, concerns, etc.
-->
---------
Co-authored-by: Avery Yingyi Huang <[email protected]>1 parent da937d7 commit 8e926de
1 file changed
+6
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2811 | 2811 | | |
2812 | 2812 | | |
2813 | 2813 | | |
2814 | | - | |
2815 | | - | |
| 2814 | + | |
| 2815 | + | |
2816 | 2816 | | |
2817 | 2817 | | |
2818 | 2818 | | |
2819 | | - | |
2820 | | - | |
| 2819 | + | |
| 2820 | + | |
| 2821 | + | |
| 2822 | + | |
2821 | 2823 | | |
2822 | 2824 | | |
2823 | 2825 | | |
| |||
0 commit comments