Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/off.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,23 @@ function off(selector, event) {
if (Array.isArray(selector)) {
selector.forEach((item) => off(item, event));
}
if (!window._domassistevents || !window._domassistevents[`_${event}`]) {
return;
if (!window._domassistevents) {
window._domassistevents = {};
}

// only disable events that were registered with domassist.on,
// don't de-register events that were registered by other libs:
const data = window._domassistevents[`_${event}`];

if (!data) {
return;
}

const el = find(selector);

if (el.length) {
el.forEach((item) => {
item.removeEventListener(event, data.cb, data.capture);
item.removeEventListener(event, data.cb, data.options);
});
}
}
Expand Down
35 changes: 16 additions & 19 deletions lib/on.js
Original file line number Diff line number Diff line change
@@ -1,41 +1,38 @@
import find from './find';

function on(selector, event, cb, capture = false) {
function on(selector, event, cb, options) {
if (Array.isArray(selector)) {
selector.forEach((item) => on(item, event, cb, capture));
selector.forEach((item) => on(item, event, cb, options));
return;
}

// scrolling events need the passive listener attached
// to satisfy SEO scrolling measurements:
if (['touchstart', 'touchmove', 'wheel', 'mousewheel', 'scroll'].indexOf(event) !== -1) {
if (capture === false) {
capture = { passive: true };
}
if (capture === true) {
capture = { passive: true, capture: true };
}
if (typeof capture === 'object') {
capture.passive = true;
}
let eventOptions = {};

if (typeof options === 'boolean') {
eventOptions.capture = options;
} else if (typeof options === 'object') {
eventOptions = { ...options };
}

const data = {
cb,
options: eventOptions
};

// _domassistevents keeps track of events we registered
// with 'domassist.on' so they can be deregistered by
// 'domassist.off' without affecting events registered
// by other libraries:
if (!window._domassistevents) {
window._domassistevents = {};
}
window._domassistevents[`_${event}`] = {
cb,
capture
};

window._domassistevents[`_${event}`] = data;
const el = find(selector);

if (el.length) {
el.forEach((item) => {
item.addEventListener(event, cb, capture);
item.addEventListener(event, cb, eventOptions);
});
}
}
Expand Down