From 63ec0db4f5652e4ff94bc82fe9ed65ef6174a6c2 Mon Sep 17 00:00:00 2001 From: Harry Terkelsen Date: Thu, 21 Nov 2019 14:58:54 -0800 Subject: [PATCH 1/3] [cloud_firestore] Fix test that used FirebaseApp.channel --- packages/cloud_firestore/test/cloud_firestore_test.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/cloud_firestore/test/cloud_firestore_test.dart b/packages/cloud_firestore/test/cloud_firestore_test.dart index be6c34d6c5cd..aa0003f07f52 100755 --- a/packages/cloud_firestore/test/cloud_firestore_test.dart +++ b/packages/cloud_firestore/test/cloud_firestore_test.dart @@ -28,10 +28,12 @@ void main() { "hasPendingWrites": false, "isFromCache": false, }; + const MethodChannel firebaseCoreChannel = MethodChannel('plugins.flutter.io/firebase_core'); + setUp(() async { mockHandleId = 0; // Required for FirebaseApp.configure - FirebaseApp.channel.setMockMethodCallHandler( + firebaseCoreChannel.setMockMethodCallHandler( (MethodCall methodCall) async {}, ); app = await FirebaseApp.configure( From 04c133f9196f56908436891917a2bfffa8f1e3e8 Mon Sep 17 00:00:00 2001 From: Harry Terkelsen Date: Thu, 21 Nov 2019 15:39:02 -0800 Subject: [PATCH 2/3] dartfmt --- packages/cloud_firestore/test/cloud_firestore_test.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/cloud_firestore/test/cloud_firestore_test.dart b/packages/cloud_firestore/test/cloud_firestore_test.dart index aa0003f07f52..7020fea2b481 100755 --- a/packages/cloud_firestore/test/cloud_firestore_test.dart +++ b/packages/cloud_firestore/test/cloud_firestore_test.dart @@ -28,7 +28,8 @@ void main() { "hasPendingWrites": false, "isFromCache": false, }; - const MethodChannel firebaseCoreChannel = MethodChannel('plugins.flutter.io/firebase_core'); + const MethodChannel firebaseCoreChannel = + MethodChannel('plugins.flutter.io/firebase_core'); setUp(() async { mockHandleId = 0; From efe38f098386df30895a6b74496ec54def07e1d0 Mon Sep 17 00:00:00 2001 From: Harry Terkelsen Date: Thu, 21 Nov 2019 15:40:22 -0800 Subject: [PATCH 3/3] bump version --- packages/cloud_firestore/CHANGELOG.md | 4 ++++ packages/cloud_firestore/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/cloud_firestore/CHANGELOG.md b/packages/cloud_firestore/CHANGELOG.md index d1f544cd5b50..16b4bb58eddd 100644 --- a/packages/cloud_firestore/CHANGELOG.md +++ b/packages/cloud_firestore/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.12.10+3 + +* Fixed test that used `FirebaseApp.channel`. + ## 0.12.10+2 * Fixed analyzer warnings about unused fields. diff --git a/packages/cloud_firestore/pubspec.yaml b/packages/cloud_firestore/pubspec.yaml index eeb1f8a2405e..2e75f1e5250b 100755 --- a/packages/cloud_firestore/pubspec.yaml +++ b/packages/cloud_firestore/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for Cloud Firestore, a cloud-hosted, noSQL database live synchronization and offline support on Android and iOS. author: Flutter Team homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_firestore -version: 0.12.10+2 +version: 0.12.10+3 flutter: plugin: